* Question about EXCHANGE_ID on server.
@ 2011-06-11 7:54 Sid Moore
2011-06-11 23:59 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Sid Moore @ 2011-06-11 7:54 UTC (permalink / raw)
To: linux-nfs
Hi
on Linux NFSv4.1 server, nfsd4_exchange_id() is used for creating a
new client incarnation or updating a confirmed client incarnation. if
try to update a confirmed incarnation, EXCHGID4_FLAG_CONFIRMED_R
should be set in eir_flags according to section 18.35.3, RFC5661.
but I found EXCHGID4_FLAG_CONFIRMED_R is cleared by "clid->flags =
new->cl_exchange_flags;", which is in nfsd4_set_ex_flags() called by
nfsd4_exchange_id().
so the sematics of RFC5661 is broken? am I correct?
The code that I browse was newly cloned from
git://linux-nfs.org/~bhalevy/linux-pnfs.git.
--
Sid
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Question about EXCHANGE_ID on server.
2011-06-11 7:54 Question about EXCHANGE_ID on server Sid Moore
@ 2011-06-11 23:59 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2011-06-11 23:59 UTC (permalink / raw)
To: Sid Moore; +Cc: linux-nfs
On Sat, Jun 11, 2011 at 03:54:56PM +0800, Sid Moore wrote:
> Hi
>
> on Linux NFSv4.1 server, nfsd4_exchange_id() is used for creating a
> new client incarnation or updating a confirmed client incarnation. if
> try to update a confirmed incarnation, EXCHGID4_FLAG_CONFIRMED_R
> should be set in eir_flags according to section 18.35.3, RFC5661.
>
> but I found EXCHGID4_FLAG_CONFIRMED_R is cleared by "clid->flags =
> new->cl_exchange_flags;", which is in nfsd4_set_ex_flags() called by
> nfsd4_exchange_id().
>
> so the sematics of RFC5661 is broken? am I correct?
On a quick glance.... I think you're correct. Patch welcomed.
--b.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-11 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-11 7:54 Question about EXCHANGE_ID on server Sid Moore
2011-06-11 23:59 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).