linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Giuzzi <luca.giuzzi@gmail.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] rpc.idmapd dies with 'I/O possible'
Date: Mon, 16 May 2011 16:47:44 +0200	[thread overview]
Message-ID: <BANLkTim0_AnmgVaqf9NTV_GwCCrcRToJxQ@mail.gmail.com> (raw)
In-Reply-To: <4DD13350.1000207@RedHat.com>

On Mon, May 16, 2011 at 4:23 PM, Steve Dickson <SteveD@redhat.com> wrote:

> I just updated the bz with these questions, but we can have the
> conversation here...
>
> I'm just a bit concerned by the fact that there are
> a couple of places that sets F_SETSIG and then sets F_NOTIFY,
> so does that mean those places are potential race cases as
> well?
>
where does this happen? There are 3 places where I have seen these fcntl's.
The first three are:
1. in idmapd.c, at nfsopen()
2. in gssd_proc.c at process_clnt_dir()
3. in gssd_main_loop.c at topdirs_add_entry()
In all of these cases, the pattern is to set the SETSIG to something useful, and
then enable NOTIFY, though; thus they should not determine a race.
[there is also a fourth one in idmapd, where the signals are actually
initialized (lines 357-360); however, in the case of failure of the
first SETSIG the daemon does not start]

> Also, after you applied this patch, did the problem go away?

I honestly don't know: the problem seems to have disappeared, in the
sense that the patched daemon has not died. However, before it
occurred with quite a random
pattern (usually, once per day per machine, but it really depended) so
I cannot be sure (it might be it was also related to the overall load
- unfortunately I do not
have the proper statistics).


best,
 lg

      parent reply	other threads:[~2011-05-16 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 13:38 [PATCH] rpc.idmapd dies with 'I/O possible' Luca Giuzzi
2011-05-16 13:56 ` Jeff Layton
2011-05-16 14:23 ` Steve Dickson
2011-05-16 14:39   ` J. Bruce Fields
2011-05-16 14:47   ` Luca Giuzzi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTim0_AnmgVaqf9NTV_GwCCrcRToJxQ@mail.gmail.com \
    --to=luca.giuzzi@gmail.com \
    --cc=SteveD@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).