From: Fred Isaman <iisaman@netapp.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@panasas.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
NFS list <linux-nfs@vger.kernel.org>
Subject: Re: Smack on the head: Questions about pnfs write path
Date: Mon, 23 May 2011 10:22:23 -0400 [thread overview]
Message-ID: <BANLkTim30-pDMWTyirSh4uT-C9zJK9XyJg@mail.gmail.com> (raw)
In-Reply-To: <4DD855CD.3060901@panasas.com>
On Sat, May 21, 2011 at 8:16 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
> On 05/22/2011 02:45 AM, Boaz Harrosh wrote:
>>
>> Fred git blame points to you:
>>
>> What was the meaning of the below code:
>>
>
> OK Smack *ME* on the head
>
> A layout driver must have a .pg_test function else
> that's what happens. pNFS only for a single page.
> I'd say it should be opposite no?
>
Right now, a driver with no pg_test function erroneously misses the
pnfs_update_layout call in multi-page io. I'll send a patch to fix
that shortly.
Fred
next prev parent reply other threads:[~2011-05-23 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 23:45 Smack on the head: Questions about pnfs write path Boaz Harrosh
2011-05-22 0:16 ` Boaz Harrosh
2011-05-23 14:22 ` Fred Isaman [this message]
2011-05-23 17:50 ` Benny Halevy
2011-05-23 17:52 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim30-pDMWTyirSh4uT-C9zJK9XyJg@mail.gmail.com \
--to=iisaman@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).