linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Please pull NFS client changes for Linux 4.7
Date: Fri, 27 May 2016 16:50:24 -0700	[thread overview]
Message-ID: <CA+55aFz6vQt-9kA0hdB-sdG4N9PzP5cp6m5NaeAV9sSLSQ41Ug@mail.gmail.com> (raw)
In-Reply-To: <57488072.6030502@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

On Fri, May 27, 2016 at 10:14 AM, Boris Ostrovsky
<boris.ostrovsky@oracle.com> wrote:
>
> This breaks on older compilers:
>
>   CC      fs/nfs/nfs4state.o
> /home/build/linux-linus/fs/nfs/nfs4state.c:69: error: unknown field
> ‘data’ specified in initializer

Does the attached patch fix it for you?

I don't have easy access to the old compiler, but I _think_ the
trivial patch of just adding braces around the data initializer should
make old gcc's happy

              Linus

[-- Attachment #2: patch.diff --]
[-- Type: text/plain, Size: 428 bytes --]

 fs/nfs/nfs4state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 5075592df145..9679f4749364 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -66,7 +66,7 @@
 #define OPENOWNER_POOL_SIZE	8
 
 const nfs4_stateid zero_stateid = {
-	.data = { 0 },
+	{ .data = { 0 } },
 	.type = NFS4_SPECIAL_STATEID_TYPE,
 };
 static DEFINE_MUTEX(nfs_clid_init_mutex);

  reply	other threads:[~2016-05-27 23:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 15:29 [GIT PULL] Please pull NFS client changes for Linux 4.7 Anna Schumaker
2016-05-27 17:14 ` Boris Ostrovsky
2016-05-27 23:50   ` Linus Torvalds [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-05-28  0:17 Boris Ostrovsky
2016-05-28  0:30 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFz6vQt-9kA0hdB-sdG4N9PzP5cp6m5NaeAV9sSLSQ41Ug@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=Anna.Schumaker@netapp.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).