From: Rakib Mullick <rakib.mullick@gmail.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] nfs: Fix unused variable warning.
Date: Tue, 1 Nov 2011 00:16:40 +0600 [thread overview]
Message-ID: <CADZ9YHgR=WHzCfJf7_T_WjHJJHzOnWZsM2bWSACwLHEcHy+h-g@mail.gmail.com> (raw)
In-Reply-To: <1320083034.4714.24.camel@lade.trondhjem.org>
On Mon, Oct 31, 2011 at 11:43 PM, Trond Myklebust
<Trond.Myklebust@netapp.com> wrote:
> On Mon, 2011-10-31 at 23:12 +0600, Rakib Mullick wrote:
>> On Mon, Oct 31, 2011 at 9:18 PM, Trond Myklebust
>> <Trond.Myklebust@netapp.com> wrote:
>> > On Fri, 2011-10-28 at 16:36 +0600, Rakib Mullick wrote:
>> + data->inode->nfs_client->cl_hostname,
> ^^^^^^^^^^^^
> NFS_SERVER(data->inode)->nfs_client....
Opss. Sorry, should've more careful, rather doing it quickly :(.
data->inode has nothing inside named nfs_client, but didn't even
complain. I'll resend it.
Anyway, I found the two following warning in nfs/file.c
fs/nfs/file.c: In function ‘nfs_file_release’:
fs/nfs/file.c:140:17: warning: unused variable ‘dentry’
fs/nfs/file.c: In function ‘nfs_file_read’:
fs/nfs/file.c:237:9: warning: unused variable ‘count’
I'm wanting to send one patch to cleanup all these unused variable
issues. Shall I? Or, should I send separate patches?
Thanks,
Rakib
next prev parent reply other threads:[~2011-10-31 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 10:36 [PATCH] nfs: Fix unused variable warning Rakib Mullick
2011-10-31 15:18 ` Trond Myklebust
2011-10-31 17:12 ` Rakib Mullick
2011-10-31 17:43 ` Trond Myklebust
2011-10-31 18:16 ` Rakib Mullick [this message]
2011-10-31 18:28 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADZ9YHgR=WHzCfJf7_T_WjHJJHzOnWZsM2bWSACwLHEcHy+h-g@mail.gmail.com' \
--to=rakib.mullick@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).