From: "Daniel Díaz" <daniel.diaz@linaro.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: brauner@kernel.org, chuck.lever@oracle.com, bfields@fieldses.org,
stable@vger.kernel.org, linux-nfs@vger.kernel.org,
gregkh@linuxfoundation.org, hch@lst.de, jlayton@kernel.org,
vegard.nossum@oracle.com, naresh.kamboju@linaro.org
Subject: Re: [PATCH 6.1.y 0/2] Address ltp nfs test failure.
Date: Fri, 25 Aug 2023 17:11:42 -0600 [thread overview]
Message-ID: <CAEUSe7_L2UtPi3Lcr4owKC83FO2zhCYDzNaWn-PKgfn9USNPvg@mail.gmail.com> (raw)
In-Reply-To: <20230825161603.371792-1-harshit.m.mogalapalli@oracle.com>
Hello!
On Fri, 25 Aug 2023 at 10:17, Harshit Mogalapalli
<harshit.m.mogalapalli@oracle.com> wrote:
> These two are backports for 6.1.y. Conflict resolution in done in
> both patches.
> I have tested LTP-nfs fchown02 and chown02 on 6.1.y with below patches
> applied. The tests passed.
I have given this a go but did not see better results.
On 6.1.48-rc1, without any extra patches:
https://lkft.validation.linaro.org/scheduler/job/6685964#L3814
https://storage.tuxsuite.com/public/linaro/lkft/builds/2UR2OCpseRQ0lu76phKZBw6l2xf/
On 6.1.48-rc1 plus this series of patches:
https://lkft.validation.linaro.org/scheduler/job/6692637#L3832
https://lkft.validation.linaro.org/scheduler/job/6692642#L3818
https://storage.tuxsuite.com/public/linaro/daniel/builds/2UUHtMsTAQeuei3gGM32NWZx82w/
In both cases:
chown02.c:46: TPASS: chown(testfile1, 0, 0) passed
chown02.c:46: TPASS: chown(testfile2, 0, 0) passed
chown02.c:58: TFAIL: testfile2: wrong mode permissions 0100700,
expected 0102700
[...]
fchown02.c:57: TPASS: fchown(3, 0, 0) passed
fchown02.c:57: TPASS: fchown(4, 0, 0) passed
fchown02.c:67: TFAIL: testfile2: wrong mode permissions 0100700,
expected 0102700
The exact same thing happened with the 5.15 patch series.
I'll be glad to test more patches.
Greetings!
Daniel Díaz
daniel.diaz@linaro.org
> I would like to have a review as I am not familiar with this code.
>
> Thanks to Vegard for helping me with this.
>
> Thanks,
> Harshit
>
> Christian Brauner (2):
> nfs: use vfs setgid helper
> nfsd: use vfs setgid helper
>
> fs/attr.c | 1 +
> fs/internal.h | 2 --
> fs/nfs/inode.c | 4 +---
> fs/nfsd/vfs.c | 4 +++-
> include/linux/fs.h | 2 ++
> 5 files changed, 7 insertions(+), 6 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-08-25 23:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 16:16 [PATCH 6.1.y 0/2] Address ltp nfs test failure Harshit Mogalapalli
2023-08-25 16:16 ` [PATCH 6.1.y 1/2] nfs: use vfs setgid helper Harshit Mogalapalli
2023-08-25 16:16 ` [PATCH 6.1.y 2/2] nfsd: " Harshit Mogalapalli
2023-08-25 23:11 ` Daniel Díaz [this message]
2023-08-26 10:00 ` [PATCH 6.1.y 0/2] Address ltp nfs test failure Harshit Mogalapalli
2023-08-27 7:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUSe7_L2UtPi3Lcr4owKC83FO2zhCYDzNaWn-PKgfn9USNPvg@mail.gmail.com \
--to=daniel.diaz@linaro.org \
--cc=bfields@fieldses.org \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=stable@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).