From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: Peng Tao <tao.peng@primarydata.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2] NFS41: make close wait for layoutreturn
Date: Wed, 23 Sep 2015 08:59:36 -0400 [thread overview]
Message-ID: <CAHQdGtRcN+76W7KhBW=0H+2SV6NtsXAqpNv6CCEGHubNaqcitw@mail.gmail.com> (raw)
In-Reply-To: <CAHQdGtReUEbzgTq_LsEUfJKDYxJfDmNmfqLURrzg_1moTt9oJw@mail.gmail.com>
On Wed, Sep 23, 2015 at 8:52 AM, Trond Myklebust
<trond.myklebust@primarydata.com> wrote:
> On Wed, Sep 23, 2015 at 8:45 AM, Kinglong Mee <kinglongmee@gmail.com> wrote:
>> On 9/23/2015 20:05, Trond Myklebust wrote:
>>> On Wed, Sep 23, 2015 at 4:27 AM, Kinglong Mee <kinglongmee@gmail.com> wrote:
>>>> I find the inode returned from nfs_igrab_and_active is NULL
>>>> in _nfs4_proc_delegreturn(),
>>>>
>>>> data->inode = nfs_igrab_and_active(inode);
>>>>
>>>> So that, NFS_I(inode) causes the panic.
>>>
>>> I've added a check for ino == NULL to nfs4_wait_on_layoutreturn()...
>>
>> Yes, that's right.
>>
>> But you add the checking at the wrong place in pnfs_wait_on_layoutreturn() at your tree.
>>
>
> Sigh...errno = ENOCOFFEE;
>
> Thanks for reviewing! I'll revert and fix up again... :-/
>
Fixed now...
Cheers
Trond
prev parent reply other threads:[~2015-09-23 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 3:35 [PATCH v2] NFS41: make close wait for layoutreturn Peng Tao
2015-09-23 7:53 ` Kinglong Mee
2015-09-23 7:55 ` Kinglong Mee
2015-09-23 8:27 ` Kinglong Mee
2015-09-23 12:05 ` Trond Myklebust
2015-09-23 12:45 ` Kinglong Mee
2015-09-23 12:52 ` Trond Myklebust
2015-09-23 12:59 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQdGtRcN+76W7KhBW=0H+2SV6NtsXAqpNv6CCEGHubNaqcitw@mail.gmail.com' \
--to=trond.myklebust@primarydata.com \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tao.peng@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).