Re: [PATCH v3 00/17] NFS: Create a common path used by reads and writes

[Trond Myklebust <trond.myklebust@primarydata.com>]

On Tue, May 6, 2014 at 9:12 AM, Anna Schumaker
<Anna.Schumaker@netapp.com> wrote:
> I noticed that much of the read and write code was almost identical, with
> only minor differences in argument types and names.  These patches seek to
> unify these two codepaths wherever possible in order to make future changes
> easier.
>
> Table of contents:
>         Patches 01 - 05: Set up common data structures.
>         Patches 06 - 10: Set up a shared rpc_call_ops struct.
>         Patches 11 - 15: Set up a shared nfs_pageio_ops struct.
>
> Some of the commit setup was moved into common code, but I'm willing to
> move this back into write.c if this looks to be a problem.
>
> Future work:
>         I have rough pNFS patches to combine the read and write paths in
>         pnfs.c.  They apply on top of Dros' multiple requests work and
>         should get more testing before I submit.
>
> Testing:
>         I tested every version of NFS using the cthon and xfs tests without
>         hitting anything new.  Any extra testing would be great seeing how
>         the read and write paths are vitally important.
>
> Changes in v3:
>         Instead of creating a new "pageio.c" file, I now put the combined
>         code into pagelist.c (good luck, Dros!)
>
>         I also renamed a few functions, and did a better job checking what
>         pagelist.c functions can now be static.
>
> Questions?  Comments?  Thoughts?
>

Thanks for working on this! Applied...

-- 
Trond Myklebust

Linux NFS client maintainer, PrimaryData

trond.myklebust@primarydata.com