From: Andy Adamson <androsadamson@gmail.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "Adamson, Andy" <William.Adamson@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] NFSv4.0 reclaim reboot state when re-establishing clientid
Date: Mon, 1 Oct 2012 19:12:12 -0400 [thread overview]
Message-ID: <CAHVgHyUJ2qLa8zGS72d0cpPtZEf=9U+YN_7G+=WaayDpSimsXA@mail.gmail.com> (raw)
In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA908FFAAF9@SACEXCMBX04-PRD.hq.netapp.com>
On Mon, Oct 1, 2012 at 6:15 PM, Myklebust, Trond
<Trond.Myklebust@netapp.com> wrote:
> On Fri, 2012-09-28 at 17:05 -0400, andros@netapp.com wrote:
>> From: Andy Adamson <andros@netapp.com>
>>
>> We should always reclaim state when the lease and therefore the clientid
>> is expired.
>>
>> Signed-off-by: Andy Adamson <andros@netapp.com>
>> ---
>> fs/nfs/nfs4state.c | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
>> index a5331ec..134323a 100644
>> --- a/fs/nfs/nfs4state.c
>> +++ b/fs/nfs/nfs4state.c
>> @@ -1600,8 +1600,8 @@ out:
>> return nfs4_recovery_handle_error(clp, status);
>> }
>>
>> -/* Set NFS4CLNT_LEASE_EXPIRED for all v4.0 errors and for recoverable errors
>> - * on EXCHANGE_ID for v4.1
>> +/* Set NFS4CLNT_LEASE_EXPIRED and reclaim reboot state for all v4.0 errors
>> + * and for recoverable errors on EXCHANGE_ID for v4.1
>> */
>> static int nfs4_handle_reclaim_lease_error(struct nfs_client *clp, int status)
>> {
>> @@ -1647,6 +1647,8 @@ static int nfs4_handle_reclaim_lease_error(struct nfs_client *clp, int status)
>> return status;
>> }
>> set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state);
>> + nfs4_state_clear_reclaim_reboot(clp);
>> + nfs4_state_start_reclaim_reboot(clp);
>
> This is probably correct for NFS4ERR_STALE_CLIENTID, but certainly not
> for NFS4ERR_SEQ_MISORDERED, or NFS4ERR_DELAY...
>
Oops - will resend with fix...
-->Andy
>> dprintk("%s: handled error %d for server %s\n", __func__, status,
>> clp->cl_hostname);
>> return 0;
>
> --
> Trond Myklebust
> Linux NFS client maintainer
>
> NetApp
> Trond.Myklebust@netapp.com
> www.netapp.com
prev parent reply other threads:[~2012-10-01 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 21:05 [PATCH 0/1] NFSv4.0 reclaim reboot state when re-establishing clientid andros
2012-09-28 21:05 ` [PATCH 1/1] " andros
2012-10-01 22:15 ` Myklebust, Trond
2012-10-01 23:12 ` Andy Adamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHVgHyUJ2qLa8zGS72d0cpPtZEf=9U+YN_7G+=WaayDpSimsXA@mail.gmail.com' \
--to=androsadamson@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).