From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "J. Bruce Fields" <bfields@fieldses.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: Disable NFSv2 timestamp workaround for NFSv3+
Date: Wed, 6 May 2015 12:12:13 +0200 [thread overview]
Message-ID: <CAHpGcMJe1YyCev2mza=pOCvs1pcV6M2AnX-0hVa4gdppnXassA@mail.gmail.com> (raw)
In-Reply-To: <20150506065651.GA22454@lst.de>
2015-05-06 8:56 GMT+02:00 Christoph Hellwig <hch@lst.de>:
> How about moving the workaround into the NFSv2 specific code?
Not trivially, we would have to fh_verify() the file handle in
nfsd_proc_setattr() first. Is that preferable?
> Looks like the call from nfsd_create() should never be used for this
> workaround,
Right, the workaround won't trigger there because setting the times
arbitrarily will already succeed because we are the owner
(nfsd_sanitize_attrs tries that first with inode_change_ok).
Thanks,
Andreas
next prev parent reply other threads:[~2015-05-06 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 6:50 [PATCH] nfsd: Disable NFSv2 timestamp workaround for NFSv3+ Andreas Gruenbacher
2015-05-06 6:56 ` Christoph Hellwig
2015-05-06 10:12 ` Andreas Grünbacher [this message]
2015-05-07 7:53 ` Christoph Hellwig
2015-05-07 14:08 ` J. Bruce Fields
2015-05-08 22:37 ` [PATCH v2] " Andreas Gruenbacher
2015-05-08 22:50 ` Andreas Grünbacher
2015-05-11 12:27 ` Christoph Hellwig
2015-05-12 18:38 ` Andreas Grünbacher
2015-05-11 12:26 ` Christoph Hellwig
2015-05-12 19:17 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHpGcMJe1YyCev2mza=pOCvs1pcV6M2AnX-0hVa4gdppnXassA@mail.gmail.com' \
--to=andreas.gruenbacher@gmail.com \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).