From: William Dauchy <wdauchy@gmail.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "Adamson, Andy" <William.Adamson@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH Version 3 1/1] NFSv4 wait on recovery for async session errors
Date: Wed, 20 Nov 2013 10:29:49 +0100 [thread overview]
Message-ID: <CAJ75kXahPFSMsec27Eu2cR2N7cNrv_cwtL9cN3At5RNU1fZC-Q@mail.gmail.com> (raw)
In-Reply-To: <1384897797.45997.1.camel@leira.trondhjem.org>
Hi Trond,
On Tue, Nov 19, 2013 at 10:49 PM, Myklebust, Trond
<Trond.Myklebust@netapp.com> wrote:
> There is a second patch that goes with this problem. Please see the
> following attachment.
ba64b36 NFSv4: Update list of irrecoverable errors on DELEGRETURN
is cc'ed for stable
If these two patches are connected, why the first one:
d3b173a NFSv4 wait on recovery for async session errors
is not cc'ed for stable as well?
For example in stable v3.10.x we currently have:
case -NFS4ERR_SEQ_MISORDERED:
dprintk("%s ERROR %d, Reset session\n", __func__,
task->tk_status);
nfs4_schedule_session_recovery(clp->cl_session, task->tk_status);
task->tk_status = 0;
return -EAGAIN;
but with the last pacthes we now have in mainline:
case -NFS4ERR_SEQ_MISORDERED:
dprintk("%s ERROR: %d Reset session\n", __func__,
errorcode);
nfs4_schedule_session_recovery(clp->cl_session, errorcode);
goto wait_on_recovery;
and this was orignally change because of commit
f1478c1 NFS: Re-use exit code in nfs4_async_handle_error()
The result in stable v3.10.x doesn't really make sense to me. Did I
missed something?
Regards,
--
William
next prev parent reply other threads:[~2013-11-20 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 21:36 [PATCH Version 3 1/1] NFSv4 wait on recovery for async session errors andros
2013-11-19 21:49 ` Myklebust, Trond
2013-11-19 22:34 ` Myklebust, Trond
2013-11-19 22:43 ` Adamson, Andy
2013-11-19 22:47 ` Myklebust, Trond
2013-11-20 9:29 ` William Dauchy [this message]
2013-11-21 23:48 ` William Dauchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ75kXahPFSMsec27Eu2cR2N7cNrv_cwtL9cN3At5RNU1fZC-Q@mail.gmail.com \
--to=wdauchy@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).