From: Olga Kornievskaia <aglo@umich.edu>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: Another question about v3 attribute handling
Date: Fri, 20 Jul 2018 15:25:38 -0400 [thread overview]
Message-ID: <CAN-5tyGDnctzTRkbVB_oT5oZc+4PiywUZQV9RYh-pT2iuxMt5Q@mail.gmail.com> (raw)
In-Reply-To: <839932d583bf0962c636f4494cf9f387d4aba6fd.camel@hammerspace.com>
On Fri, Jul 20, 2018 at 2:50 PM, Trond Myklebust
<trondmy@hammerspace.com> wrote:
> On Fri, 2018-07-20 at 14:44 -0400, Olga Kornievskaia wrote:
>> Hi Trond,
>>
>> This is a different question but is related to the attribute
>> handling.
>>
>> What I see in v4, is that say the client received a reply to the OPEN
>> with before and after change_attr values for the directory. We check
>> if the before value is the same as what we have in the cache and if
>> it's not then we invalidate the directory attributes.
>>
>> It seems that we don't have similar check for the v3. If in v3, the
>> server returned a before that was different from what could be seen
>> on
>> the network trace as the before for the directory, it does not
>> trigger
>> invalidation. Is this expected because it's v3 or is this a bug?
>
> Doesn't the call to nfs_post_op_update_inode(dir, data->res.dir_attr)
> in nfs3_do_create() do the right thing?
Dah, I knew I was missing something. Thanks.
prev parent reply other threads:[~2018-07-20 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 18:44 Another question about v3 attribute handling Olga Kornievskaia
2018-07-20 18:50 ` Trond Myklebust
2018-07-20 19:25 ` Olga Kornievskaia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN-5tyGDnctzTRkbVB_oT5oZc+4PiywUZQV9RYh-pT2iuxMt5Q@mail.gmail.com \
--to=aglo@umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).