linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stef Bon <stefbon@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Anand Avati <avati@gluster.com>,
	fuse-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] fuse: permit O_DIRECT flag in open()
Date: Fri, 22 Jul 2011 17:02:02 +0200	[thread overview]
Message-ID: <CANXojcxyjBBPRYTxkiBGNzTFnirWnfH5_ZGMiahgMzNKkaL8gg@mail.gmail.com> (raw)
In-Reply-To: <87livqfnin.fsf@tucsk.pomaz.szeredi.hu>

I do not like it. Setting O_DIRECT to the flags is an option which
should be set in the filesystem, not in the general library.

I'm working on a overlay fs with various backends, like a normal (part
of) partition on a ATA harddisk, a USB stick, a Cdrom, a mounted SMB
share.... and it is able to set the O_DIRECT flag, but always per
backend.

Stef

2011/7/22 Miklos Szeredi <miklos@szeredi.hu>:
> Anand Avati <avati@gluster.com> writes:
>
>> but do not permit setting of O_DIRECT flag via fcntl() (or unsetting)
>
> Again, some more verbose description would be good, as well as a

  reply	other threads:[~2011-07-22 15:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22  8:33 [PATCH 1/2] vfs: pass 'struct file *' as parameter to ->check_flags() methods Anand Avati
2011-07-22  8:33 ` [PATCH 2/2] fuse: permit O_DIRECT flag in open() Anand Avati
2011-07-22 13:33   ` Miklos Szeredi
2011-07-22 15:02     ` Stef Bon [this message]
2011-07-22 13:26 ` [PATCH 1/2] vfs: pass 'struct file *' as parameter to ->check_flags() methods Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANXojcxyjBBPRYTxkiBGNzTFnirWnfH5_ZGMiahgMzNKkaL8gg@mail.gmail.com \
    --to=stefbon@gmail.com \
    --cc=avati@gluster.com \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).