Re: [PATCH 3/6] fhandle: do_handle_open() should get FD with user flags

[Amir Goldstein <amir73il@gmail.com>]

On Fri, Aug 15, 2025 at 1:52 AM Thomas Bertschinger
<tahbertschinger@gmail.com> wrote:
>
> In f07c7cc4684a, do_handle_open() was switched to use the automatic
> cleanup method for getting a FD. In that change it was also switched
> to pass O_CLOEXEC unconditionally to get_unused_fd_flags() instead
> of passing the user-specified flags.
>
> I don't see anything in that commit description that indicates this was
> intentional, so I am assuming it was an oversight.
>
> With this fix, the FD will again be opened with, or without, O_CLOEXEC
> according to what the user requested.
>
> Fixes: f07c7cc4684a ("fhandle: simplify error handling")
> Signed-off-by: Thomas Bertschinger <tahbertschinger@gmail.com>

This patch does not seem to be conflicting with earlier patches in the series
but it is still preferred to start the series with the backportable fix patch.

Fee free to add:
Reviewed-by: Amir Goldstein <amir73il@gmail.com>

Thanks,
Amir.

> ---
>  fs/fhandle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fhandle.c b/fs/fhandle.c
> index 57da648ca866..dbb273a26214 100644
> --- a/fs/fhandle.c
> +++ b/fs/fhandle.c
> @@ -409,7 +409,7 @@ static long do_handle_open(int mountdirfd, struct file_handle __user *ufh,
>         if (retval)
>                 return retval;
>
> -       CLASS(get_unused_fd, fd)(O_CLOEXEC);
> +       CLASS(get_unused_fd, fd)(open_flag);
>         if (fd < 0)
>                 return fd;
>
> --
> 2.50.1
>
>