linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nelson Elhage <nelhage@nelhage.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nfs@vger.kernel.org, Bruce Fields <bfields@fieldses.org>,
	James Brown <jbrown@easypost.com>
Subject: Re: NFSv3 may inappropriately return EPERM for fsetxattr
Date: Mon, 21 Mar 2016 08:56:03 -0700	[thread overview]
Message-ID: <CAPSG9dZX45Uq07Xue55Aom3i-WyH9_SA_SKydBjsEX1Y14VwoA@mail.gmail.com> (raw)
In-Reply-To: <20160321144349.GA12804@lst.de>

That's correct. The other detail that seems to be important is that
the user making the call must be different from the user owning the
file. We've also been using user remapping on the server, so that
non-xattr calls succeed in that configuration.

The reproducer James added in the bugzilla is:

(on machine with IP address 10.1.1.1)
sudo mkdir /nfs_test
sudo useradd -u 10000 test_user
sudo chown test_user /nfs_test
echo "/nfs_test 10.1.1.2(rw,all_squash,anonuid=10000)" | sudo tee -a
/etc/exports
sudo exportfs -a

(on machine with IP address 10.1.1.2)
sudo mkdir /nfs_test
sudo mount -t nfs -o vers=3,noacl 10.1.1.1:/nfs_test /nfs_test
touch /nfs_test/foo
install -m 755 /nfs_test/foo /nfs_test/bar

- Nelson

On Mon, Mar 21, 2016 at 7:43 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Hi Nelson,
>
> this was indeed most likely caused by my patch.  Just to narrow things
> down can your clarify that the scenarious is that you have CONFIG_NFS_V3
> set on your client, you're talking to a server not supporting ACLs
> at all, and a tool trying to set an ACL is getting the wrong return
> value?  If so I should be able to reproduce this locally.

  reply	other threads:[~2016-03-21 15:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  3:46 NFSv3 may inappropriately return EPERM for fsetxattr Nelson Elhage
2016-03-21 14:43 ` Christoph Hellwig
2016-03-21 15:56   ` Nelson Elhage [this message]
2018-08-10  1:29     ` NeilBrown
2018-08-10 17:00       ` Bruce Fields
2018-08-10 17:03         ` Bruce Fields
2018-08-11 22:28           ` NeilBrown
2018-08-12 13:21             ` Bruce Fields
2018-08-12 23:55               ` NeilBrown
2018-08-14  9:03                 ` NeilBrown
2018-08-14 19:43                   ` Bruce Fields
2018-08-14 23:49                     ` NeilBrown
2018-08-16  0:39                     ` NeilBrown
2018-08-16 17:54                       ` Bruce Fields
2018-08-16 22:50                         ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPSG9dZX45Uq07Xue55Aom3i-WyH9_SA_SKydBjsEX1Y14VwoA@mail.gmail.com \
    --to=nelhage@nelhage.com \
    --cc=bfields@fieldses.org \
    --cc=hch@lst.de \
    --cc=jbrown@easypost.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).