From: "Thomas Bertschinger" <tahbertschinger@gmail.com>
To: "Amir Goldstein" <amir73il@gmail.com>
Cc: <io-uring@vger.kernel.org>, <axboe@kernel.dk>,
<linux-fsdevel@vger.kernel.org>, <viro@zeniv.linux.org.uk>,
<brauner@kernel.org>, <linux-nfs@vger.kernel.org>
Subject: Re: [PATCHSET RFC 0/6] add support for name_to, open_by_handle_at(2) to io_uring
Date: Fri, 15 Aug 2025 12:24:03 -0600 [thread overview]
Message-ID: <DC37MILZEZV8.2P3JEY8VJ66DO@gmail.com> (raw)
In-Reply-To: <CAOQ4uxij17qNiTq6Gjy0Q_aOv8-k9ggsZ3vFA1Uz-tw-gS7xxQ@mail.gmail.com>
On Fri Aug 15, 2025 at 3:52 AM MDT, Amir Goldstein wrote:
> On Fri, Aug 15, 2025 at 1:50 AM Thomas Bertschinger
> <tahbertschinger@gmail.com> wrote:
>> No attempt is made to support a non-blocking open_by_handle_at()--the
>> attempt is always immediately returned with -EAGAIN if
>> IO_URING_F_NONBLOCK is set.
>>
>> This isn't ideal and it would be nice to add support for non-blocking
>> open by handle in the future. This would presumably require updates to
>> the ->encode_fh() implementation for filesystems that want to
>> support this.
>
> Correction: ->encode_fh() is for name_to_handle()
> You want to say that ->fh_to_dentry() need to support cached lookup,
Yes, that is what I meant, whoops.
> but FWIW, the blocking code is more likely to come from the
> lookup in exportfs_decode_fh_raw() => ... reconnect_one()
> not from the filesystem code.
>
> The fs would "only" need to be taught to return an alias to a
> cached inode and generic code would "only" need to be taught
> to give up on a disconnected dir dentry.
>
> Doesn't sound too hard (famous last words).
>
> Thanks,
> Amir.
>
Thanks for the ideas on how to support this!
next prev parent reply other threads:[~2025-08-15 18:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 23:54 [PATCHSET RFC 0/6] add support for name_to, open_by_handle_at(2) to io_uring Thomas Bertschinger
2025-08-14 23:54 ` [PATCH 1/6] fhandle: create helper for name_to_handle_at(2) Thomas Bertschinger
2025-08-15 10:21 ` Amir Goldstein
2025-08-15 18:17 ` Thomas Bertschinger
2025-08-14 23:54 ` [PATCH 2/6] io_uring: add support for IORING_OP_NAME_TO_HANDLE_AT Thomas Bertschinger
2025-08-15 10:40 ` Amir Goldstein
2025-08-16 7:43 ` kernel test robot
2025-08-14 23:54 ` [PATCH 3/6] fhandle: do_handle_open() should get FD with user flags Thomas Bertschinger
2025-08-15 9:17 ` Amir Goldstein
2025-08-15 13:46 ` Christian Brauner
2025-08-15 13:51 ` Amir Goldstein
2025-08-19 9:43 ` Christian Brauner
2025-08-15 13:47 ` (subset) " Christian Brauner
2025-08-14 23:54 ` [PATCH 4/6] fhandle: create __do_handle_open() helper Thomas Bertschinger
2025-08-15 10:33 ` Amir Goldstein
2025-08-14 23:54 ` [PATCH 5/6] io_uring: add __io_open_prep() helper Thomas Bertschinger
2025-08-14 23:54 ` [PATCH 6/6] io_uring: add support for IORING_OP_OPEN_BY_HANDLE_AT Thomas Bertschinger
2025-08-16 10:10 ` kernel test robot
2025-08-15 9:52 ` [PATCHSET RFC 0/6] add support for name_to, open_by_handle_at(2) to io_uring Amir Goldstein
2025-08-15 18:24 ` Thomas Bertschinger [this message]
2025-08-19 15:11 ` Jens Axboe
2025-08-20 3:01 ` Thomas Bertschinger
2025-08-20 8:34 ` Amir Goldstein
2025-08-20 15:05 ` Thomas Bertschinger
2025-08-20 19:58 ` Amir Goldstein
2025-08-21 7:47 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC37MILZEZV8.2P3JEY8VJ66DO@gmail.com \
--to=tahbertschinger@gmail.com \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).