linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleg Drokin <green@linuxhacker.ru>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jeff Layton <jlayton@poochiereds.net>,
	"<linux-kernel@vger.kernel.org> Mailing List"
	<linux-kernel@vger.kernel.org>,
	"<linux-fsdevel@vger.kernel.org>" <linux-fsdevel@vger.kernel.org>,
	linux-nfs@vger.kernel.org
Subject: Re: Dcache oops
Date: Sat, 4 Jun 2016 12:12:14 -0400	[thread overview]
Message-ID: <DF4A1130-84CD-4083-92B4-6DEA2D633753@linuxhacker.ru> (raw)
In-Reply-To: <20160604005611.GA14480@ZenIV.linux.org.uk>


On Jun 3, 2016, at 8:56 PM, Al Viro wrote:

> On Fri, Jun 03, 2016 at 07:58:37PM -0400, Oleg Drokin wrote:
> 
>>> EOPENSTALE, that is...  Oleg, could you check if the following works?
>> 
>> Yes, this one lasted for an hour with no crashing, so it must be good.
>> Thanks.
>> (note, I am not equipped to verify correctness of NFS operations, though).
> 
> I suspect that Jeff Layton might have relevant regression tests.  Incidentally,
> we really need a consolidated regression testsuite, including the tests you'd
> been running.  Right now there's some stuff in xfstests, LTP and cthon; if
> anything, this mess shows just why we need all of that and then some in
> a single place.  Lustre stuff has caught a 3 years old NFS bug (missing
> d_drop() in nfs_atomic_open()) and a year-old bug in handling of EOPENSTALE
> retries on the last component of a trailing non-embedded symlink.  Neither
> is hard to trigger; it's just that relevant tests hadn't been run on NFS,
> period.

BTW, the nets also have brought in another use after free in nfs4 state
tracking code (this is the one I was trying to hunt down from the start).
I'll submit a patch shortly.
And also there's a mysterious ext4 data corruption that I do not really fully
understand but only hit once so far.

  parent reply	other threads:[~2016-06-04 16:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <74306F63-DBDF-4DED-85D2-5C3FB21B8A1E@linuxhacker.ru>
     [not found] ` <20160603182203.GR14480@ZenIV.linux.org.uk>
     [not found]   ` <4285E00F-7228-485C-AD32-97552ED746F2@linuxhacker.ru>
     [not found]     ` <20160603200759.GS14480@ZenIV.linux.org.uk>
     [not found]       ` <CA+55aFznPit97evuwZHdCG55=N0QbkFSST2ydKxvExQTR-YXTg@mail.gmail.com>
     [not found]         ` <20160603212652.GT14480@ZenIV.linux.org.uk>
     [not found]           ` <CA+55aFyYkbXqoJ3PqfrnxWDEXJM_BH6Q_OdKf+UVJYEUF4gdQA@mail.gmail.com>
     [not found]             ` <20160603222355.GW14480@ZenIV.linux.org.uk>
     [not found]               ` <20160603223700.GY14480@ZenIV.linux.org.uk>
     [not found]                 ` <DA67EEEA-D769-4D0F-9C20-6145F2B0808F@linuxhacker.ru>
2016-06-04  0:56                   ` Dcache oops Al Viro
2016-06-04 12:25                     ` Jeff Layton
2016-06-04 16:12                     ` Oleg Drokin [this message]
2016-06-04 16:21                       ` [PATCH] nfs4: Fix potential use after free of state in nfs4_do_reclaim green
2016-06-04 19:57                         ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF4A1130-84CD-4083-92B4-6DEA2D633753@linuxhacker.ru \
    --to=green@linuxhacker.ru \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).