From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795126894; b=kWPglVuunRgZ0GgaYrvPUZ8O7hBGSFx5KRCf1zLZwbe9VPhWP9VISLWOmEHbQTeamjLr Y4qtKQwUiZ/WXzTVuFXFg+q4osktlbIZWrEHf57TcOQm7DfCkZp2C7Voh8FTodyE7LIaB zsp4flzQ24dT2KpumSBgYOnZVXtPxCp8A1hP2OqW/68/HSp0MQm9oSX+B16obXCTo0/oj sRpO6WPR/+xHnC/Z3icZqpBnVRne7gsjVA3ETZtsinnAceP1k8zg1HnSGWArChX3/z22d bWAWrOL7LyB5tWL8BIFEskl6s7k2WzZkrXWSMeg0XyASq81QgBbRFpqIbFDoAT7j+yg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795126894; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To:X-Mailer: References:In-Reply-To; bh=DXopmfH8M4TtkeX0mLmdjIDJGntKSuAqE61ScQWgHrM=; b=B55a6daBkMltd4inkyayUKl8SqsrAax/uCaLM0WK8PqHhqNA/4hRk+M+U4bkbdV0cnOE 2wjvKvsJdC/dEWQ1fjAlNRm9z6mlWetjzgVR6RBWtu6/KudIyUcoWdjJQgmVaRHG9uhDS WV+EEiuacgd3sGtBx1+LFl8K3vTlzEaS7LwcBssYbGNgMONV8BKvHNNNzPXLpGqWoinf1 FWxOZA1WzljlMR0r9KTI2n/vN4qiQQ8ggB30aZUJoaIjN1S/sFy9/xNbzszMK1NFF00BW r3Lkv7ASfylrF/dspJu9oZjAWTD0JDdChTrs1NxBSUlwOqgvG/xk6XSNrbW8ZU3QC8Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=gef0lchy; arc=none smtp.remote-ip=209.85.221.42 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCEB0606A330 for ; Thu, 19 Nov 2026 22:21:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BCEB0606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=gef0lchy Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-490d59c3f0aso98458f8f.1 for ; Thu, 19 Nov 2026 14:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795126892; x=1795731692; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:from:to:cc:subject:date:message-id :reply-to:content-type; bh=DXopmfH8M4TtkeX0mLmdjIDJGntKSuAqE61ScQWgHrM=; b=gef0lchyyswlM17vKmxXh1yKD4D8BKuG+NQIPtAdUNOAGP/k24f7fDcob5s8n+r9hE Op3nPHSw2Yc6V71RtCnGfLLeMIhn9KNHGiCiNeXIPi+tsuRCjAe3GTu1PabZIjb4kgKK yVMgvdEPJUB8hshUa/1LWEbi/FTHFVt7W+mqj+oOyWVsgwyKDtHSazpyimgU6ZR3JwNS wa/iqeL6R59NNa6gMbdrpyewG+vFeim/3Gd07HmSOYr2ZZyD26/IiAfztdWP9TrnbluY JsgFUZYAel71x+uOm2BxTKumTYG2LAV8SN53OPap5xMaJ6osumK+9XrzlkeH5ysrpXV4 GL/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795126892; x=1795731692; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=DXopmfH8M4TtkeX0mLmdjIDJGntKSuAqE61ScQWgHrM=; b=p7a8NSTLva3PgqwRCdNFJe3dk/VmDSCBS9KTzWpR4O2CwDpCDyWpl55OqNOisF9Vy0 8ZnXeKcPTpCmvQgq5yqMVDXPtjOmTDbIGvycvnm7xf3GojlVPwR/U91S3n9ZqJFVbj3H 38WY2H6YqnxxuyXmLY7WAfuxiRiVqumWH/d5NeY3MbEGwBuoee+V4ZGdZX5DDmFV0QiG b5cIWCk2VA/y59gLlSX0wk4m2X6DWgbHx/vyQmBWBw8yFAcT47vEQYf5g3Go/GtM3+s9 qi6QmGrnDJD8bEtaqzUdpI/CTEVxIfU0ow6yNrtDO4RGHWKeKMcu+WiQG90DPnQY6ytX Bekg== X-Forwarded-Encrypted: i=1; AL+hErFkVbZ2AdDROlVnzcw4IuYpBbk3xmI5FcprUjuWGAcqznA7p0IJqphr+ixoxRBAA4CGYoeA1VaRhew=@vger.kernel.org X-Gm-Message-State: APuU4Z8Sr4QFsZTHCSwXZmQ31jjMeQc9ZRMnKNVgBVBcqX4pzn7Om5mi C9PzhOPg97aovFRq8ZZiy0OHEwgJIeLy6ckYDOZZA6AgdGs+ebxKVfl1 X-Gm-Gg: AZFdTZfV8spv6CysKlAyYg0Kov1k1yEceC/QPgoeMZRLrLC7sATq0ImXkXcWezgJ0JR bpKAThi+OmuGeRBQw8HPV+gCi4jOjXuSC0EEbmjMv8bFg+qnsKR35T1u6EmeD+douWN1wcFgq5n RlFycTKM8M0uOReVzmMc60zQ42JkT7iad5HoR7pDuMpTMCPjkcxBMvc2txoVksyYJo0FTAZbEMg oNd7dqWbRMIdEtC9CepVguuwVZONFb2DX67wJwqpvAV5jjs5epMDq2K+8ZLUpjIAnWTri2ARcvy +BGBA5BvmApPYAEngVNuhGn2XoYy+L+8C8ts0EGj6Rm0A3vvEZ8iq9Xcs1KvVD+aNu/b0xJSPYC BM55HBmEgZAlbHEeRhyt3a1fwzCrjH8gUhZuNc3K7mNx+EeJD1cxq7O/IAn2uwBTu4oQTfGWQ1P Y1NUARU1VJiZIK/cUdGcCZ/auWj3g6EG0Qk0RYu3/Vr/cF+0qo0/Ov09pKRpRAZX3CFE5+kJsC+ 3e6LTI17ZN+5bP6kqwwPH8ngF9k/dlsEt6fIWqxGmZnfhVuu/tXyDed8hArAUdJzc6J/mHZ/FaG Eeeg3LVavqolOLK27jst1oeqww== X-Received: by 2002:a05:6000:25c2:b0:4a6:7781:b064 with SMTP id ffacd0b85a97d-4abb51457e8mr1841184f8f.31.1795126891984; Thu, 19 Nov 2026 14:21:31 -0800 (PST) Received: from localhost ([2001:b07:5d26:7a6a:365a:60ff:fe0d:cfc6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab69bf61f3sm2102936f8f.17.2026.11.19.14.21.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2026 14:21:31 -0800 (PST) X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: multipart/signed; boundary=1118862003b65829f4e4ebf4d4274973bc4a2074b1863740606dca9d7054; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Thu, 19 Nov 2026 23:21:30 +0100 Message-Id: Cc: "Lauri Gates" , "Dave Chinner" , "Christian Brauner" , "Christoph Hellwig" , , "Carlos Maiolino" , "Christian Brauner" , "Darrick J. Wong" , , , , , , Subject: Re: Concurrent FIEMAP on reflinked files serialises on the AGF buffer lock From: "koraynilay" To: "Amir Goldstein" , "koraynilay" X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261119095943.85048-1-lauri.gates@gmail.com> In-Reply-To: --1118862003b65829f4e4ebf4d4274973bc4a2074b1863740606dca9d7054 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Thu Nov 19, 2026 at 6:04 PM CET, Amir Goldstein wrote: > On Thu, Nov 19, 2026 at 12:00=E2=80=AFPM koraynilay = wrote: >> >> On Thu Nov 19, 2026 at 10:59 AM CET, Lauri Gates wrote: >> > On Wed, Nov 18, 2026 at 10:16PM +0200, Dave Chinner wrote: >> >> I really don't care if it is exposed by statx or file_attr; checking >> >> the flag through either interface will be orders of magnitude faster >> >> than using FIEMAP to iterate extents on every file to find shared >> >> extents. My concern with statx is coherency - it runs completely >> >> unlocked and so can race with operations that add/remove the reflink >> >> flag... >> > >> > Thanks, Dave and Christian. Given Christian's preference and the >> > coherency point, I'll write the RFC against file_attr, once the >> > question at the end is settled. xfs_fileattr_get() already reads the >> > flags under XFS_ILOCK_SHARED, so the new flag gets that without extra >> > work. The answer can still go stale right after the call, as with any >> > stat result: a clone that lands after the read is missed, just as one >> > that lands after FIEMAP returns is missed today. >> > >> > As I suggested on the 6th, the flag would take the inverted meaning, >> > so that an unset flag stays the safe answer: say FS_XFLAG_NOSHARED >> > ("no extents shared with another file"), read-only, in >> > FS_XFLAG_RDONLY_MASK next to the case-folding flags. >> >> Hello, I don't have any say in the FIEMAP issue, but I wanted to let you >> know that, since also a mask was mentioned and your patch would be >> touching the fileattr API, there is work going[1] on for adding a >> fsx_xflags_mask that filesystem use[2][3] to advertise supported flags (= on >> get, like stx_attributes_mask) and users use to say what they want to >> change (on set). >> It doesn't seem like an FS_XFLAG_NOSHARED flag would touch this new >> change, but I thought it was worth pointing out, especially because this >> patch would also add FS_XFLAG_PROJID and a new FS_FILE_ATTR_XFLAGS_MASK >> to have a way to include both legacy and newly added xflags, so >> FS_XFLAG_NOSHARED would maybe also go there (correct me if I'm wrong). >> >> > Christian, one question on the shape within file_attr: would you take >> > the inverted flag, or would you rather keep a plain "may share" flag >> > and add a mask to struct file_attr that says which xflags the >> > filesystem reports? >> >> And if Christian chooses the mask approach, then my patch[4] becomes >> relevant. >> (in [4] I put the patch that will be sent in v5 of [1], since in [1] >> it's merged with the ptime change) >> >> (For Amir who I just CC'd, [5] is the main link for this thread) > > Thanks for the CC and the link > >> >> Thanks, >> koraynilay >> >> [1]: https://lore.kernel.org/all/20261115180343.576773-1-koray.fra@gmail= .com/T/#u >> [2]: https://lore.kernel.org/all/CAOQ4uxj82K4z+2OiY5W1g7NyWAFOFjqqWnZSS3= prytW36j1LgA@mail.gmail.com/ >> [3]: https://lore.kernel.org/all/CAOQ4uxiuJ=3DeZu28FZAUz3rpqPKqCimPxJucO= nYYuBowvD09_Cw@mail.gmail.com/ >> [5]: https://lore.kernel.org/linux-xfs/20261102193533.93690-1-lauri.gate= s@gmail.com/T/#u >> >> [4]: >> commit 0efe0de3b5cc2b767aa6e2bb9174eb05b0d818f1 >> Author: koraynilay >> Date: Tue Nov 17 14:57:47 2026 +0100 >> >> vfs: add xflags mask to file_attr API >> >> Add fa_xflags_mask to struct file_attr and equivalent fsx_xflags_mas= k >> to struct file_kattr. >> >> This lets filesystems advertise their support for specific xflags an= d >> users specify only what they want to change, behaving like >> statx.stx_attributes_mask: >> - on GET (file_getattr): each filesystem fills the mask according to >> its supported xflags, e.g. FS_XFLAG_COWEXTSIZE or FS_XFLAG_EXTSIZE= , >> and provides the values in the corresponding struct fields; >> - on SET (file_setattr): userspace fills the mask according to which >> xflags it wants to change, VFS validates this and preserves xflags >> that were not specified in the mask; >> - if xflags_mask =3D=3D 0, use legacy full-struct replacement to kee= p >> compatibility with older programs. >> >> Furthermore, add the missing FS_XFLAG_PROJID flag, to allow userspac= e to >> set the projid using file_[sg]etattr(). > > Correction. usersapce can already set projid using file_[sg]etattr(). > With FS_XFLAG_PROJID in fsx_xflags_mask, chattr -p > could set the projid without having to read and set all the other xflags. Oh right, thanks, I'll fix it. >> >> Finally, in order to prevent the legacy FS_IOC_FSSETXATTR from accep= ting >> FS_XFLAG_PROJID, add an FS_FILE_ATTR_XFLAGS_MASK to support new xfla= gs >> and use it in fileattr_to_file_attr()/file_attr_to_fileattr() to >> validate that the xflags passed in fa_xflags and fa_xflags_mask fiel= ds >> are valid. >> >> Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.5.7 >> Signed-off-by: koraynilay >> --- >> fs/file_attr.c | 46 +++++++++++++++++++++++++++++++++++++++++= +---- >> include/linux/fileattr.h | 5 +++++ >> include/uapi/linux/fs.h | 3 +++ >> 3 files changed, 50 insertions(+), 4 deletions(-) >> >> diff --git a/fs/file_attr.c b/fs/file_attr.c >> index 833e03810b24..56ea65f790f1 100644 >> --- a/fs/file_attr.c >> +++ b/fs/file_attr.c >> @@ -102,10 +102,18 @@ EXPORT_SYMBOL(vfs_fileattr_get); >> static void fileattr_to_file_attr(const struct file_kattr *fa, >> struct file_attr *fattr) >> { >> - __u32 mask =3D FS_XFLAGS_MASK; >> + /* >> + * fsx_xflags_mask contains only flags added after the >> + * file_[gs]etattr() API, so we need to tell userspace the files= ystem >> + * actually supports all legacy (FS_XFLAGS_MASK and FS_XFLAG_PRO= JID, >> + * which lacked its own bit) and new advertised flags. >> + */ >> + __u32 mask =3D (FS_XFLAGS_MASK | FS_XFLAG_PROJID | fa->fsx_xflag= s_mask) & >> + FS_FILE_ATTR_XFLAGS_MASK; > > This is not exactly how I envisioned exporting fa_xflags_mask. This is exactly why I CC'd you :D > fa_xflags_mask =3D=3D 0 means old kernel or unmodified fs. > > For a new kernel with fs that supports flags other than > FS_XFLAGS_MASK it's the fs responsibility to advertise its supported > flags. > > Something like: > > __u32 mask =3D (fa->fsx_xflags_mask ?: FS_XFLAGS_MASK) & > FS_FILE_ATTR_XFLAGS_MASK; > > memset(fattr, 0, sizeof(struct file_attr)); (I'm sorry, but why memset if we assign the fields right after?) > fattr->fa_xflags =3D fa->fsx_xflags & mask; > fattr->fa_xflags_mask =3D fa->fsx_xflags_mask ? mask : 0; > > Then you can add filesystems that support get/set of new > attributes without support for legacy attributes. > > And specific filesytems could opt-into the set of an individual > attribute like projid by advertising > fa->fsx_xflags_mask =3D FS_XFLAGS_MASK | FS_XFLAG_PROJID > or a subset thereof. I agree, this is definitely better. > And I am still on the fence wrt should API also advertise the > fsx_xflags_ro_mask in addition to the supported mask. > > The advantage being that it makes the interface symmetric. > User can alway setattr() with the buffer they got from getattr() > and instead of randomly ignoring flags in set, the fsx_ro_mask > along with fsx_mask defines the behavior exactly. Hmm, so ro_mask would be ignored by vfs on set so users don't have to manually remove the read only flags, correct? Also I think I'll try writing some basic userspace programs that use this API and see how I'd expect it to be. Anyway, I think it would be better to split the _mask change into its own separate patch series, so it can more easily be used by this shared extent patch and it's easier to reason about the API when it's disconnected from the ptime/btime change. Thanks, koraynilay > Thanks, > Amir. --1118862003b65829f4e4ebf4d4274973bc4a2074b1863740606dca9d7054 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSgVimKafU5DQMcjcDmj22qf5IGXAUCav92agAKCRDmj22qf5IG XDQZAQC8F1HjZwQYe3nM4A7edE2Sz/q0zyveg6sGz+2hCxvXnQEAgWogwdag2wgs tOMOPQGJhAKoiAMhC2Wt5uBfklZ/hgI= =npK3 -----END PGP SIGNATURE----- --1118862003b65829f4e4ebf4d4274973bc4a2074b1863740606dca9d7054--