From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E1DA1EB193 for ; Wed, 8 Oct 2025 19:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950163; cv=none; b=sUZH8Bv0yORO7FmxGNOnUuA1Rkasb/WmiesP7SppFmcqPB2yI6RHZhp0pWzx6dZhFQExuFXjQC5iMiL8K1xpE6IXx8WGr3Fbfcq6ybxWHvo1ask9FWN8SGn+7tWLGVeK8fVnuHnZE+5mYOyOXG16/CKyXMj//kBGZGpXGqsoaU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759950163; c=relaxed/simple; bh=x6Cx+2/65U4Z4aV1uw4U7kRIfruYof5JPA52WE6aH1g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VZcabub+v6FG/WzQzMbEO+4s4Y84PNIhZtr9M4E2urPtD2l0YSJdhlcH6YAXrfSRl+EjbGIcEcXlsVnH4qZKrYuEgSQ3YBNo8k0cyqOrK0nezsQoUkHGk0bMAlgPtA6qsM0AJz9HUSAhLTiKr7Xol3aMrRxSaPD7TwBYD/PMVwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=W0eM3WhZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W0eM3WhZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759950161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FHoLIPpvkEXMktd+Uj29/fm80mbfI/FGCSM/Gp/0uUI=; b=W0eM3WhZzRoEp2kSTli4NtDIyF9WeYm/MbdqM3HDyc9Guo7fBelkcIHWJ43+LBa+AUVC9h ekFESMcIUxOCnRyFhbnlr1UnRswluwbAtHoijBleJ1MvKtulJo1BRDfeIfY22b51OxS5dN tE91j+4iq+JF/mGH8Bbl6pmuyt01vJ8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-Gxd4Ntv8MXCnnUEwyPCYCw-1; Wed, 08 Oct 2025 15:02:37 -0400 X-MC-Unique: Gxd4Ntv8MXCnnUEwyPCYCw-1 X-Mimecast-MFC-AGG-ID: Gxd4Ntv8MXCnnUEwyPCYCw_1759950155 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 624D8180057A; Wed, 8 Oct 2025 19:02:35 +0000 (UTC) Received: from [172.16.1.51] (unknown [10.22.89.77]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A4BA1800452; Wed, 8 Oct 2025 19:02:34 +0000 (UTC) From: Benjamin Coddington To: Joshua Watt Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Trond Myklebust , Anna Schumaker Subject: Re: [PATCH] NFS4: Apply delay_retrans to async operations Date: Wed, 08 Oct 2025 15:02:32 -0400 Message-ID: In-Reply-To: <20251007212452.599683-1-JPEWhacker@gmail.com> References: <20251007212452.599683-1-JPEWhacker@gmail.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 7 Oct 2025, at 17:22, Joshua Watt wrote: > From: Joshua Watt > > The setting of delay_retrans is applied to synchronous RPC operations > because the retransmit count is stored in same struct nfs4_exception > that is passed each time an error is checked. However, for asynchronous > operations (READ, WRITE, LOCKU, CLOSE, DELEGRETURN), a new struct > nfs4_exception is made on the stack each time the task callback is > invoked. This means that the retransmit count is always zero and thus > delay_retrans never takes effect. > > Apply delay_retrans to these operations by tracking and updating their > retransmit count. Looks correct. I wish we didn't have to assign these values back and forth, but I don't see a better way to fix this. Reviewed-by: Benjamin Coddington Ben