Re: [PATCH 1/7] filelock: add a new locks_inode_context accessor function

Jeff Layton
2022-11-16T17:43:55Z

On Wed, 2022-11-16 at 08:08 -0800, Christoph Hellwig wrote:
> On Wed, Nov 16, 2022 at 10:17:20AM -0500, Jeff Layton wrote:
> > - ctx = smp_load_acquire(&inode->i_flctx);
> > + ctx = locks_inode_context(inode);
>
> Nit: this might be a good time to drop the weird double space here.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Fixed the nit in my tree.

After sending this, I converted locks_remove_file to use the helper too.
I also think we probably need to use this helper in
locks_free_lock_context.

Folded all 3 changes into this patch, and pushed to my linux-next feeder
branch.

Thanks Christoph!
--
Jeff Layton <jlayton@kernel.org>