public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: NeilBrown <neilb@suse.de>
Cc: "J . Bruce Fields" <bfields@fieldses.org>,
	linux-nfs@vger.kernel.org, Steve Dickson <steved@redhat.com>,
	Chuck Lever <chuck.lever@oracle.com>,
	Alexey Kodanev <alexey.kodanev@oracle.com>
Subject: Re: Re: [PATCH/RFC nfs-utils] Fix NFSv4 export of tmpfs filesystems.
Date: Thu, 13 May 2021 20:38:59 +0200	[thread overview]
Message-ID: <YJ1yQ3fga7YGRRI9@pevik> (raw)
In-Reply-To: <162087884172.5576.348023037121213464@noble.neil.brown.name>

Hi Neil,

> On Fri, 07 May 2021, Petr Vorel wrote:
> > Hi Neil,

> > > [[This is a proposed fix.  It seems to work.  I'd like
> > >   some review comments before it is committed.
> > >   Petr: it would be great if you could test it to confirm
> > >   it actually works in your case.
> > > ]]
> > Thanks for a quick fix. It runs nicely in newer kernels (5.11.12-1-default
> > openSUSE and 5.10.0-6-amd64 Debian). But it somehow fails on older ones
> > (SLES 5.3.18-54-default heavily patched and 4.9.0-11-amd64).

> > I have some problem on Debian with 4.9.0-11-amd64 fails on both tmpfs and ext4,
> > others work fine (testing tmpfs, btrfs and ext4). But maybe I did something
> > wrong during testing. I did:
> > cp ./utils/mountd/mountd /usr/sbin/rpc.mountd
> > systemctl restart nfs-mountd.service

> That is the correct procedure.  It should work...
Thanks for a confirmation.


> > Failure is regardless I use new mount.nfs (master) or the original from
> > Debian (1.3.3).

> What error message do you get on failure? It might help to add "-v" to
> the mount command to see more messages.
+1. I'll add it to the tests (+ printing mount.nfs version).

Here is debug info (when using nfs-utils 2.5.3 - master, with your patch):
* NFSv3 on ext4 (OK)
nfs01 1 TINFO: setup NFSv3, socket type tcp
nfs01 1 TINFO: Mounting NFS: mount -v -t nfs -o proto=tcp,vers=3 10.0.0.2:/var/tmp/LTP_nfs01.14F4lC51P6/3/tcp /var/tmp/LTP_nfs01.14F4lC51P6/3/0
mount.nfs: trying 10.0.0.2 prog 100003 vers 3 prot TCP port 2049
mount.nfs: trying 10.0.0.2 prog 100005 vers 3 prot TCP port 58997
mount.nfs: timeout set for Thu May 13 08:22:46 2021
mount.nfs: trying text-based options 'proto=tcp,vers=3,addr=10.0.0.2'
mount.nfs: prog 100003, trying vers=3, prot=6
mount.nfs: prog 100005, trying vers=3, prot=6
nfs01 1 TINFO: starting 'nfs01_open_files 10'

* NFSv3 on tmpfs (OK)
nfs01 1 TINFO: setup NFSv3, socket type tcp
nfs01 1 TINFO: Mounting NFS: mount -v -t nfs -o proto=tcp,vers=3 10.0.0.2:/tmp/LTP_nfs01.oJEz2xd9ZI/3/tcp /tmp/LTP_nfs01.oJEz2xd9ZI/3/0
mount.nfs: trying 10.0.0.2 prog 100003 vers 3 prot TCP port 2049
mount.nfs: trying 10.0.0.2 prog 100005 vers 3 prot TCP port 58997
mount.nfs: timeout set for Thu May 13 08:23:01 2021
mount.nfs: trying text-based options 'proto=tcp,vers=3,addr=10.0.0.2'
mount.nfs: prog 100003, trying vers=3, prot=6
mount.nfs: prog 100005, trying vers=3, prot=6
nfs01 1 TINFO: starting 'nfs01_open_files 10'

* NFSv4.1 on tmpfs (FAIL)
nfs01 1 TINFO: setup NFSv4.1, socket type tcp
nfs01 1 TINFO: Mounting NFS: mount -v -t nfs -o proto=tcp,vers=4.1 10.0.0.2:/tmp/LTP_nfs01.QnnFGEV4rs/4.1/tcp /tmp/LTP_nfs01.QnnFGEV4rs/4.1/0
mount.nfs: mount(2): No such file or directory
mount.nfs: mounting 10.0.0.2:/tmp/LTP_nfs01.QnnFGEV4rs/4.1/tcp failed, reason given by server: No such file or directory
mount.nfs: timeout set for Thu May 13 08:23:02 2021
mount.nfs: trying text-based options 'proto=tcp,vers=4.1,addr=10.0.0.2,clientaddr=10.0.0.1'
nfs01 1 TBROK: mount command failed
nfs01 1 TINFO: Cleaning up testcase

> > strace looks nearly the same on tmpfs and ext4:

> This shows mount.nfs connecting to rpcbind, sending a request, getting a
> reply, and maybe looping around and trying again?

> There doesn't seem to be anything kernel related that would affect
> anything there so I cannot think why on older kernel would make a
> difference.  Or an older rpcbind...
Well, it uses 1.2.5-0.3+deb10u1, i.e. nearly the latest version (Steve released
1.2.6 3 days ago). And it's the same version as in openSUSE Tumbleweed where it
works well.


> Maybe I'll experiment on a SLE12 kernel.
Thanks!

> NeilBrown

Kind regards,
Petr

  reply	other threads:[~2021-05-13 18:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 19:18 [RFC PATCH 1/1] mount.nfs: Fix mounting on tmpfs Petr Vorel
2021-04-22 20:23 ` J . Bruce Fields
2021-04-23  2:17   ` Petr Vorel
2021-04-23 14:23     ` J . Bruce Fields
2021-04-23 17:04       ` Petr Vorel
2021-04-23 18:13         ` J . Bruce Fields
2021-04-23 20:37           ` Petr Vorel
2021-05-03  2:21           ` NeilBrown
2021-05-03  8:10             ` Petr Vorel
2021-05-03 14:15             ` J . Bruce Fields
2021-04-23 13:50   ` Petr Vorel
2021-05-07  1:48     ` [PATCH/RFC nfs-utils] Fix NFSv4 export of tmpfs filesystems NeilBrown
2021-05-07 10:06       ` Petr Vorel
2021-05-13  4:07         ` NeilBrown
2021-05-13 18:38           ` Petr Vorel [this message]
2021-05-13 18:51             ` Petr Vorel
2021-05-17  3:08               ` NeilBrown
2021-05-17 14:27                 ` Petr Vorel
2021-05-07 13:55       ` Chuck Lever III
2021-05-07 23:13         ` NeilBrown
2021-05-17  4:45       ` [PATCH/RFC v2 " NeilBrown
2021-05-17 15:00         ` Petr Vorel
2021-05-18 17:54         ` Petr Vorel
2021-05-20 17:37         ` Steve Dickson
2021-05-20 20:39           ` Petr Vorel
2021-05-21  1:38           ` NeilBrown
2021-05-21  1:40             ` [PATCH nfs-utils 1/2] Remove 'force' arg from cache_flush() NeilBrown
2021-05-21  1:41               ` [PATCH nfs-utils 2/2] Move declaration of etab and rmtab into libraries NeilBrown
2021-05-21 13:57                 ` Petr Vorel
2021-05-23 18:31                 ` Steve Dickson
2021-05-21 13:52               ` [PATCH nfs-utils 1/2] Remove 'force' arg from cache_flush() Petr Vorel
2021-05-23 18:30               ` Steve Dickson
2021-05-23 18:29         ` [PATCH/RFC v2 nfs-utils] Fix NFSv4 export of tmpfs filesystems Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ1yQ3fga7YGRRI9@pevik \
    --to=pvorel@suse.cz \
    --cc=alexey.kodanev@oracle.com \
    --cc=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox