From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "bfields@fieldses.org" <bfields@fieldses.org>,
"nickhuang@synology.com" <nickhuang@synology.com>,
"chuck.lever@oracle.com" <chuck.lever@oracle.com>,
"robbieko@synology.com" <robbieko@synology.com>,
"bingjingc@synology.com" <bingjingc@synology.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory
Date: Sat, 15 May 2021 08:02:39 +0100 [thread overview]
Message-ID: <YJ9yD1S6Yl2m0gOO@infradead.org> (raw)
In-Reply-To: <00195ec8bf1752306f549540eed74c3938c5e312.camel@hammerspace.com>
On Fri, May 14, 2021 at 03:46:57PM +0000, Trond Myklebust wrote:
> Why leave the commit_metadata() call under the lock? If you're
> concerned about latency, then it makes more sense to call fh_unlock()
> before flushing those metadata updates to disk.
Also I'm not sure why the extra inode reference is needed. What speaks
against just moving the dput out of the locked section?
next prev parent reply other threads:[~2021-05-15 7:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 3:58 [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory Nick Huang
2021-05-14 15:09 ` J. Bruce Fields
2021-05-14 15:46 ` Trond Myklebust
2021-05-15 7:02 ` Christoph Hellwig [this message]
2021-05-17 18:56 ` bfields
2021-05-18 7:33 ` Christoph Hellwig
2021-05-18 17:53 ` Trond Myklebust
2021-05-18 18:21 ` bfields
2021-05-18 18:36 ` Trond Myklebust
2021-05-18 18:39 ` bfields
2021-05-18 21:06 ` bfields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ9yD1S6Yl2m0gOO@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=bingjingc@synology.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nickhuang@synology.com \
--cc=robbieko@synology.com \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox