From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF19C433B4 for ; Fri, 21 May 2021 13:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 993A6611AD for ; Fri, 21 May 2021 13:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233423AbhEUN7g (ORCPT ); Fri, 21 May 2021 09:59:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:44466 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236441AbhEUN6r (ORCPT ); Fri, 21 May 2021 09:58:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9D4ACAC11; Fri, 21 May 2021 13:57:23 +0000 (UTC) Date: Fri, 21 May 2021 15:57:21 +0200 From: Petr Vorel To: NeilBrown Cc: Steve Dickson , "J . Bruce Fields" , linux-nfs@vger.kernel.org, Chuck Lever , Alexey Kodanev Subject: Re: [PATCH nfs-utils 2/2] Move declaration of etab and rmtab into libraries Message-ID: Reply-To: Petr Vorel References: <20210422191803.31511-1-pvorel@suse.cz> <20210422202334.GB25415@fieldses.org> <162035212343.24322.12361160756597283121@noble.neil.brown.name> <162122673178.19062.96081788305923933@noble.neil.brown.name> <289c5819-917a-39a7-9aa4-2a27ae7248c0@RedHat.com> <162156113063.19062.9406037279407040033@noble.neil.brown.name> <162156122215.19062.11710239266795260824@noble.neil.brown.name> <162156127225.19062.3275458295434454950@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162156127225.19062.3275458295434454950@noble.neil.brown.name> Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Neil, > There are two global "struct stat_paths" structures: etab and rmtab. > They are currently needed by some library code so any program which is > linked with that library code needs to declare the structures even if it > doesn't use the functionality. This is clumsy and error-prone. > Instead: have the library declare the structure and put the definition > in a header file. Now programs only need to know about these structures > if they use the functionality. > 'rmtab' is now declared in libnfs.a (rmtab.c). 'etab' is declared in > export.a (xtab.c). Reviewed-by: Petr Vorel Nice cleanup! Kind regards, Petr