Re: [PATCH v2] nfsrahead: fix linking while static linking

Giulio Benetti
2022-08-10T21:43:50Z

Hi All,

please drop this patch in favor of upcoming V3. This is not a good way
to use pkg-config with Autotools.

Sorry for the noise

Best regards
--
Giulio Benetti
Benetti Engineering sas

On 10/08/22 00:33, Giulio Benetti wrote:
> -lmount must preceed -lblkid and to obtain this let's add:
> `pkg-config --libs mount`
> in place of:
> `-lmount`
> This ways the library order will always be correct.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * modify pkg-conf to pkg-config
> ---
> tools/nfsrahead/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
> index 845ea0d5..280a2eb4 100644
> --- a/tools/nfsrahead/Makefile.am
> +++ b/tools/nfsrahead/Makefile.am
> @@ -1,6 +1,6 @@
> libexec_PROGRAMS = nfsrahead
> nfsrahead_SOURCES = main.c
> -nfsrahead_LDFLAGS= -lmount
> +nfsrahead_LDFLAGS= `pkg-config --libs mount`
> nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
>
> man5_MANS = nfsrahead.man