Re: [PATCH v3] nfsrahead: fix linking while static linking

Steve Dickson
2022-09-13T17:07:23Z

On 8/22/22 4:33 PM, Giulio Benetti wrote:
> Hi Steve, Petr,
>
> On 22/08/22 21:17, Steve Dickson wrote:
>>
>>
>> On 8/11/22 4:36 PM, Giulio Benetti wrote:
>>> Hi Petr,
>>>
>>>> Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <pvorel@suse.cz>
>>>> ha scritto:
>>>>
>>>> ﻿Hi,
>>>>
>>>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>>>
>>>> nit (not worth of reposting): I'm not a native speaker, but IMHO
>>>> subject should
>>>> be without while, e.g. "fix order on static linking"
>>>
>>> Totally, it sounds awful as it is now.
>>> I ask maintainers if it’s possible to reword like Petr
>>> pointed.
>> Will do!
>
> Thank you!
>
> I will try to improve the pkg-config autotools because as it is now it
> works but it’s not a good solution.
>
> I should use what it’s been suggested to me here:
> https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
> And I’ve given another solution:
> https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
> but it’s still not ok:
> https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.html
I don't have access to those list...

>
> So for the moment it’s a decent solution indeed it’s been committed to
> Buildroot
> but I’ll try to improve it once I’ll have time.
Sounds like a plan...

steved.

>
> Kind regards
> —
> Giulio Benetti
> CEO/CTO@Benetti Engineering sas
>
>> steved.
>>>
>>> Thank you all.
>>>
>>> Best regards
>>> Giulio
>>>
>>>>
>>>> Kind regards,
>>>> Petr
>>>
>>
>