Re: [PATCH] nfs: add dummy definition for nfsd_file

Jeff Johnson
2025-03-26T15:33:37Z

On 3/26/2025 8:09 AM, Mike Snitzer wrote:
> Add dummy definition for nfsd_file in both nfslocalio.c and localio.c
> so older gcc (e.g. EL8's 8.5.0) can be used. Older gcc causes RCU
> code (rcu_dereference and rcu_access_pointer) to dereference what
> should just be an opaque pointer with its use of typeof.
>
> So without the dummy definition compiling with older gcc fails.
>
> Link: https://lore.kernel.org/all/Zsyhco1OrOI_uSbd@kernel.org/
> Fixes: 55a9742d02eff ("nfs: cache all open LOCALIO nfsd_file(s) in client")

I saw this issue using crosstools/gcc-13.3.0-nolibc and this patch fixes it.

Tested-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>

> Signed-off-by: Mike Snitzer <snitzer@hammerspace.com>

note this doesn't match the From: address