Re: [PATCH v2] nfs: add dummy definition for nfsd_file

Vincent Mailhol
2025-04-23T06:49:18Z

On 23/04/2025 at 09:32, NeilBrown wrote:
> On Wed, 23 Apr 2025, Pali Rohár wrote:
>> On Wednesday 23 April 2025 07:54:40 NeilBrown wrote:
>>> On Wed, 23 Apr 2025, Pali Rohár wrote:
>>> Actually I do object to this fix (though I've been busy and hadn't had
>>> much change to look at it properly).
>>> The fix is ugly. At the very least it should be wrapping in an
>>> #if GCC_VERSION < whatever
>>
>> The problem is that this compile issue happens also with some builds of
>> gcc 13.3.0 as was discussed in the email thread.
>>
>> So is not clear what is that "whatever". For me it looks like that it
>> would be more than the version, probably also some build characteristics
>> of gcc. But I have not been investigating it deeper.
>
> Fair enough - let's skip that idea then.

If someone wants to investigate, here is a minimal reproducer:

https://godbolt.org/z/sxvYPzY6b

(personnally, I have no plans to further investigate).

Yours sincerely,
Vincent Mailhol