Re: [PATCH v2] nfs: add dummy definition for nfsd_file

Vincent Mailhol
2025-04-16T02:41:50Z

+CC: Neil Brown
+CC: Olga Kornievskaia
+CC: Dai Ngo
+CC: Tom Talpey
+CC: Trond Myklebust
+CC: Anna Schumaker

(just to make sure that anyone listed in

./scripts/get_maintainer.pl fs/nfs_common/nfslocalio.c

get copied).

Here is the link to the full thread:

https://lore.kernel.org/all/Z_coQbSdvMWD92IA@kernel.org/

On 10/04/2025 at 11:09, Mike Snitzer:
> Add dummy definition for nfsd_file in both nfslocalio.c and localio.c
> so various compilers (e.g. gcc 8.5.0 and 9.5.0) can be used. Otherwise
> RCU code (rcu_dereference and rcu_access_pointer) will dereference
> what should just be an opaque pointer (by using typeof(*ptr)).
>
> Fixes: 86e00412254a ("nfs: cache all open LOCALIO nfsd_file(s) in client")
> Cc: stable@vger.kernel.org
> Tested-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
> Tested-by: Pali Rohár <pali@kernel.org>
> Tested-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>

Hi everyone,

The build has been broken for several weeks already. Does anyone have
intention to pick-up this patch?

(please ignore if someone already picked it up and if it is already on
its way to Linus's tree).

Thank you,

Yours sincerely,
Vincent Mailhol