From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A44BC77B61 for ; Fri, 28 Apr 2023 13:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346256AbjD1Nrl (ORCPT ); Fri, 28 Apr 2023 09:47:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjD1Nrk (ORCPT ); Fri, 28 Apr 2023 09:47:40 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A0D8E0 for ; Fri, 28 Apr 2023 06:47:39 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-3ef6e84945dso32392321cf.2 for ; Fri, 28 Apr 2023 06:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1682689658; x=1685281658; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QqPNfVx26MQj/dMuYkTl831M4b4W22oDuuEzlBZ7FGo=; b=NHFJis7Ci8k1UBNxbRot/k1/RtYdm2T1qiXnLF4OoUzl49fNUjSS7EnzBO7r75GAHE a85Y70CfGPTfGKp9xVDwMbaxt3PXLUA29I7ek9urwSXaYw4XJ3/ia2pIqeGAx+nNyAAQ BrVhgxMBjihjpxSw65Rk63yNtm8cRyVCJwfvThQ9qdkuLgfz+sFAsAVy9Hkt9fNL3E3N Mz+v3eqGOYGcm4hMFXbd0I3IxEy3/mY728G0nuRyunhsb/BCce8fJmYxjHUDyoSxqtk5 p2gpRMfFixBTEecLmBReFmF+LFultJ9ywfPlteymSOGALhEj+qLKPLMdEyV+KCW/gSiR r6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682689658; x=1685281658; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QqPNfVx26MQj/dMuYkTl831M4b4W22oDuuEzlBZ7FGo=; b=bLOtV1NGs8vpaZgGzVlKHbk2E4EJZcmAyknIUcKmVcKwLOSFWzTYXPXoWbcdLonDK8 iS1G+8N7F5xK3Gx01hWtTnFsvkXcVqHWq17pNT47MSdkkj5ekEXpJCQBo3PDnwF+Wopx g43geHzyslDZ41STKq+CTwUAW9BPpdcHELz6hJhkOtL/6uSLeVTQJm8cndLJTlZtj+V8 zqiGnXpsNexX3ypBeL5IXcK/tmOa0/hCl5uN6f0EazsCk676Qf4gfDMg+eqlIVrw/Vcw zio9uLKvnhWllfA7pbNnV73sfZveDKn1DYI/jPxmyG09wuQacC1k72AdjsWmXP+6KRtJ ks3A== X-Gm-Message-State: AC+VfDxAp4+AoaxO2RiSp/Yk1g/Hcz3WJoUrBFWfmrlfBL18Doz8NqPH hDmuWGsZhblSUmvufRzZpyjwxA== X-Google-Smtp-Source: ACHHUZ4CWkyIGX6bpvoP71nXeehZzVBpYL3HbSLWAm+1TxSW8Bs/4EqkD5e2SdZJXOJKvJ8VzYe+Wg== X-Received: by 2002:ac8:4e41:0:b0:3f2:626:9c3 with SMTP id e1-20020ac84e41000000b003f2062609c3mr3275151qtw.36.1682689658719; Fri, 28 Apr 2023 06:47:38 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id x1-20020ac81201000000b003e69c51cf53sm7054187qti.72.2023.04.28.06.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 06:47:38 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1psORl-003CLs-K9; Fri, 28 Apr 2023 10:47:37 -0300 Date: Fri, 28 Apr 2023 10:47:37 -0300 From: Jason Gunthorpe To: Chuck Lever III Cc: Chuck Lever , Bernard Metzler , linux-rdma , Linux NFS Mailing List Subject: Re: [PATCH RFC] RDMA/core: Store zero GIDs in some cases Message-ID: References: <168261567323.5727.12145565111706096503.stgit@oracle-102.nfsv4bat.org> <34E28C03-5D1A-4DAA-9B5B-D453F8C256BD@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34E28C03-5D1A-4DAA-9B5B-D453F8C256BD@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, Apr 28, 2023 at 01:42:24PM +0000, Chuck Lever III wrote: > > > > On Apr 28, 2023, at 9:39 AM, Jason Gunthorpe wrote: > > > > On Thu, Apr 27, 2023 at 01:14:43PM -0400, Chuck Lever wrote: > >> From: Bernard Metzler > >> > >> Tunnel devices have zero GIDs, so skip the zero GID check when > >> setting up soft iWARP over a tunnel device. > > > > Huh? Why? How does that make any sense? > > Read it as a cry for help. > > The scenario is attempting to set up a soft iWARP device > with a slave that is a tunnel device. The set up seems to > work, but when connecting, the ULP gets an ADDR_ERROR > because the setup did not add an entry to the GID table. Don't assign a 0 IP to the tunnel? Jason