Linux NFS development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: open list <linux-kernel@vger.kernel.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: contention on pwq->pool->lock under heavy NFS workload
Date: Fri, 23 Jun 2023 15:44:15 -1000	[thread overview]
Message-ID: <ZJZKb4CvyKmHBwmg@slm.duckdns.org> (raw)
In-Reply-To: <7E9EF026-EF8B-4125-AB00-A1E9F0F907C5@oracle.com>

Hey,

On Fri, Jun 23, 2023 at 02:37:17PM +0000, Chuck Lever III wrote:
> I'm using NFS/RDMA for my test because I can drive more IOPS with it.
> 
> I've found that setting the nfsiod and rpciod workqueues to "cpu"
> scope provide the best benefit for this workload. Changing the
> xprtiod workqueue to "cpu" had no discernible effect.
> 
> This tracks with the number of queue_work calls for each of these
> WQs. 59% of queue_work calls during the test are for the rpciod
> WQ, 21% are for nfsiod, and 2% is for xprtiod.
> 
> The same test with TCP (using IP-over-IB on the same physical network)
> shows no improvement on any test. That suggests there is a bottleneck
> somewhere else, when using TCP, that limits its throughput.

Yeah, you can make the necessary workqueues to default to CPU or SMT scope
using apply_workqueue_attrs(). The interface a bit cumbersome and we
probably wanna add convenience helpers to switch e.g. affinity scopes but
it's still just several lines of code.

Thanks.

-- 
tejun

  reply	other threads:[~2023-06-24  1:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 15:26 contention on pwq->pool->lock under heavy NFS workload Chuck Lever III
2023-06-21 21:28 ` Tejun Heo
2023-06-22 14:38   ` Chuck Lever III
2023-06-22 15:45   ` Chuck Lever III
2023-06-22 19:23     ` Tejun Heo
2023-06-22 19:39       ` Chuck Lever III
2023-06-23 14:37         ` Chuck Lever III
2023-06-24  1:44           ` Tejun Heo [this message]
2023-06-25 16:01             ` Chuck Lever III
2023-06-26 20:21               ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJZKb4CvyKmHBwmg@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox