From: Chuck Lever <chuck.lever@oracle.com>
To: David Howells <dhowells@redhat.com>
Cc: Chuck Lever <cel@kernel.org>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 2/5] SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call
Date: Mon, 24 Jul 2023 09:27:54 -0400 [thread overview]
Message-ID: <ZL58WsAxz3Gj/Jlt@tissot.1015granger.net> (raw)
In-Reply-To: <64140.1690192730@warthog.procyon.org.uk>
On Mon, Jul 24, 2023 at 10:58:50AM +0100, David Howells wrote:
> Chuck Lever <cel@kernel.org> wrote:
>
> > + buf = page_frag_alloc(&svsk->sk_frag_cache, sizeof(marker),
> > + GFP_KERNEL);
>
> Is this SMP-safe? page_frag_alloc() does no locking.
Note that svc_tcp_sendto() takes xprt->xpt_mutex. There can be only
one thread (per svsk) running in svc_tcp_sendmsg() at a time.
--
Chuck Lever
next prev parent reply other threads:[~2023-07-24 13:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 18:30 [PATCH v3 0/5] Send RPC-on-TCP with one sock_sendmsg() call Chuck Lever
2023-07-19 18:31 ` [PATCH v3 1/5] SUNRPC: Convert svc_tcp_sendmsg to use bio_vecs directly Chuck Lever
2023-07-26 12:13 ` David Howells
2023-07-19 18:31 ` [PATCH v3 2/5] SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call Chuck Lever
2023-07-24 9:58 ` David Howells
2023-07-24 13:27 ` Chuck Lever [this message]
2023-07-26 12:13 ` David Howells
2023-07-19 18:31 ` [PATCH v3 3/5] SUNRPC: Convert svc_udp_sendto() to use the per-socket bio_vec array Chuck Lever
2023-07-26 12:15 ` David Howells
2023-07-26 13:11 ` Chuck Lever
2023-07-19 18:31 ` [PATCH v3 4/5] SUNRPC: Revert e0a912e8ddba Chuck Lever
2023-07-26 12:14 ` David Howells
2023-07-19 18:31 ` [PATCH v3 5/5] SUNRPC: Reduce thread wake-up rate when receiving large RPC messages Chuck Lever
2023-07-26 12:13 ` [PATCH v3 0/5] Send RPC-on-TCP with one sock_sendmsg() call David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL58WsAxz3Gj/Jlt@tissot.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=cel@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox