Re: [PATCH v4 2/2] NFSD: add rpc_status entry in nfsd debug filesystem

kernel test robot
2023-07-29T05:18:14Z

Hi Lorenzo,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20230728]
[cannot apply to trondmy-nfs/linux-next linus/master v6.5-rc3 v6.5-rc2 v6.5-rc1 v6.5-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Bianconi/SUNRPC-add-verbose-parameter-to-__svc_print_addr/20230729-024652
base: next-20230728
patch link: https://lore.kernel.org/r/a23a0482a465299ac06d07d191e0c9377a11a4d1.1690569488.git.lorenzo%40kernel.org
patch subject: [PATCH v4 2/2] NFSD: add rpc_status entry in nfsd debug filesystem
config: alpha-defconfig (https://download.01.org/0day-ci/archive/20230729/202307291354.ujwCaQTt-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291354.ujwCaQTt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307291354.ujwCaQTt-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

fs/nfsd/nfssvc.c: In function 'nfsd_rpc_status_show':
>> fs/nfsd/nfssvc.c:1241:44: error: implicit declaration of function 'nfsd4_op_name'; did you mean 'nfsd_rename'? [-Werror=implicit-function-declaration]
1241 | nfsd4_op_name(rqstp_info.opnum[j]),
| ^~~~~~~~~~~~~
| nfsd_rename
>> fs/nfsd/nfssvc.c:1240:50: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat=]
1240 | seq_printf(m, " %s%s",
| ~^
| |
| char *
| %d
1241 | nfsd4_op_name(rqstp_info.opnum[j]),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
cc1: some warnings being treated as errors

vim +1241 fs/nfsd/nfssvc.c

1216
1217 /* In order to detect if the RPC request is pending and
1218 * RPC info are stable we check if rq_status_counter
1219 * has been incremented during the handler processing.
1220 */
1221 if (status_counter != atomic_read(&rqstp->rq_status_counter))
1222 continue;
1223
1224 seq_printf(m,
1225 "0x%08x, 0x%08lx, 0x%08x, NFSv%d, %s, %016lld,",
1226 be32_to_cpu(rqstp_info.rq_xid),
1227 rqstp_info.rq_flags,
1228 rqstp_info.rq_prog,
1229 rqstp_info.rq_vers,
1230 rqstp_info.pc_name,
1231 ktime_to_us(rqstp_info.rq_stime));
1232
1233 seq_printf(m, " %s,",
1234 __svc_print_addr(&rqstp_info.saddr, buf,
1235 sizeof(buf), false));
1236 seq_printf(m, " %s,",
1237 __svc_print_addr(&rqstp_info.daddr, buf,
1238 sizeof(buf), false));
1239 for (j = 0; j < opcnt; j++)
> 1240 seq_printf(m, " %s%s",
> 1241 nfsd4_op_name(rqstp_info.opnum[j]),
1242 j == opcnt - 1 ? "," : "");
1243 seq_puts(m, "\n");
1244 }
1245 }
1246
1247 rcu_read_unlock();
1248
1249 return 0;
1250 }
1251

--
0-DAY CI Kernel Test Service