From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A30C25B47 for ; Fri, 27 Oct 2023 07:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbjJ0HcN (ORCPT ); Fri, 27 Oct 2023 03:32:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234963AbjJ0HcM (ORCPT ); Fri, 27 Oct 2023 03:32:12 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 681CB1AC; Fri, 27 Oct 2023 00:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XUhRTa+EsGph2BWAVH5/gahdxEY1XjevoZ+UMDgxahc=; b=QalpgjWKNZB5f8GyX3gE5UCa1X seQTj9WSb67Gq8qsg7gG0ujIzvU7i1GTBkqPjjB9u6E292tnZ1vJVAnBIvJ+bLM+T6722rNdeJb7N +OVtkrfrOrN0CGpw5ldaz+WNm8eGEeUAGW1782z1wFHM/ZwLIEigKLnzzQP2XNYehXMMFf3WKbQ2n TrEUvM99GYxY3kzar28K+dTurUYc5+6KwrsNx2axsxQHJwkqC96OfOxcGlEJZ7VvXvTsSmN8N3X65 zFaCdEq1AU9zpEumAndvLCsqwMTCBH4jiRqzhoWBBBId65KYzQGB01dNKroYiEyQ3XMzJxYPWYylv sMdxOQ4w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qwHKB-00FnxS-1i; Fri, 27 Oct 2023 07:32:07 +0000 Date: Fri, 27 Oct 2023 00:32:07 -0700 From: Christoph Hellwig To: Amir Goldstein Cc: Christoph Hellwig , Christian Brauner , Al Viro , Jan Kara , Jeff Layton , Chuck Lever , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 3/4] exportfs: define FILEID_INO64_GEN* file handle types Message-ID: References: <20231023180801.2953446-1-amir73il@gmail.com> <20231023180801.2953446-4-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, Oct 27, 2023 at 09:43:01AM +0300, Amir Goldstein wrote: > > Presumable the same for fuse, but for that > > I'd need to look at how it works for fuse right now and if there's not > > some subtle differences. > > > > There are subtle differences: > 1. fuse encodes an internal nodeid - not i_ino > 2. fuse encodes the inode number as [low32,high32] > > It cannot use the generic helper. That's what I almost feared. It still should use the common symbolic name for the format just to make everyones life simpler.