From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NDuZEcsn" Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CBACD5A for ; Tue, 5 Dec 2023 21:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jSXMUEwEKlogqLJouY8bxkG+ev/shBNNrzwfarR0D18=; b=NDuZEcsn+rw6YFX+llrunbvXw2 M8OrR3doFjw/lvcxu8unHx9moAzv+LATf/q9hPJN/WLvhiaFjLgNmm7UBEpEO1sfo4frJrEf/fDuZ CIl8RSi4FngIU4eQcaqI5SSc7AuSYyHvt9AlC4oLEM1js5WVqk/RyMR09KUv+ewxPoT2G1y+N3L8O c39NwCtZWlHrW6TaRSYFbezbzzWUhBcJF0kkTSqN6TawoU41KLCzjkHjh3EHUIgzxhnaUjXRx7O0G vQ1nYUChg8w4o/Dt7MqBLaT7gqvuItpSXC4S7cuIkEj9vUsr5FqfNLTH/5rIaoO9WrGVFdeqr0k99 IO2G/vkA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAkhv-0097ep-28; Wed, 06 Dec 2023 05:44:27 +0000 Date: Tue, 5 Dec 2023 21:44:27 -0800 From: Christoph Hellwig To: Benjamin Coddington Cc: trond.myklebust@hammerspace.com, anna@kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 2/2] pnfs/blocklayout: Don't add zero-length pnfs_block_dev Message-ID: References: <33e0ddfaad92ca5d6b0a4d1cc7541cf5a7480d7a.1701788600.git.bcodding@redhat.com> <53e2ab90d83d4cdc15f1b48b2eb671ad26f54a6a.1701788600.git.bcodding@redhat.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53e2ab90d83d4cdc15f1b48b2eb671ad26f54a6a.1701788600.git.bcodding@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Dec 05, 2023 at 10:05:02AM -0500, Benjamin Coddington wrote: > We noticed a SCSI device that refused to allow READ CAPACITY when the > device had a PR with exclusive access, registrants only. The result of > this situation is that the blocklayout driver adds a pnfs_block_dev of zero > length which always fails the offset_in_map tests. Instead of continuously > trying to do pNFS for this case, just mark the device as unavailable which > will allow the client to fallback to the MDS for the duration of > PNFS_DEVICE_RETRY_TIMEOUT. Looks good: Reviewed-by: Christoph Hellwig