From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="guhoCuv+" Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19ADC18F for ; Tue, 5 Dec 2023 21:46:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iXV4UMaZldrBkuQdUhhDw+67C3gjjFG2Cm6ABxsBhck=; b=guhoCuv+YDpP9cdTVK7YISHdM2 zv8exdZfydKTErbUtEBgH3mznUdn+NQaRKVgMqfdN/275fQf8zRUgko0WhBSOS3qrft+WbCHiAXXz 5QCeWJNbhqdEkMm6KjEgDkGGwEOeQBo7fFMeCwi0Hh1EeQ+gZXSkXUynFNZt+prI26ViepgV7KXID P8bqJlPEyQVcqNjgGGIBZ2FZtTYdiYo3SXpwYm7mBOyndFRMAsCx0DdwVEoKrMRij43CcW2gAPXO2 k0r9TyuDgIe8TaIEoprMuLCfNEUNswt8ZaJQOCqtolzT4SQAYkHWIDVKGcac7MzehkHfCal60Ha8S DuoLlBOQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAkje-0097kR-2m; Wed, 06 Dec 2023 05:46:14 +0000 Date: Tue, 5 Dec 2023 21:46:14 -0800 From: Christoph Hellwig To: Benjamin Coddington Cc: trond.myklebust@hammerspace.com, anna@kernel.org, linux-nfs@vger.kernel.org Subject: Re: [RESEND PATCH] NFSv4: Always ask for type with READDIR Message-ID: References: Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html > - FATTR4_WORD0_RDATTR_ERROR, > + FATTR4_WORD0_TYPE|FATTR4_WORD0_RDATTR_ERROR, Missing spaces before and after the |. > FATTR4_WORD1_MOUNTED_ON_FILEID, > }; > uint32_t dircount = readdir->count; > @@ -1612,7 +1612,7 @@ static void encode_readdir(struct xdr_stream *xdr, const struct nfs4_readdir_arg > unsigned int i; > > if (readdir->plus) { > - attrs[0] |= FATTR4_WORD0_TYPE|FATTR4_WORD0_CHANGE|FATTR4_WORD0_SIZE| > + attrs[0] |= FATTR4_WORD0_CHANGE|FATTR4_WORD0_SIZE| > FATTR4_WORD0_FSID|FATTR4_WORD0_FILEHANDLE|FATTR4_WORD0_FILEID; > attrs[1] |= FATTR4_WORD1_MODE|FATTR4_WORD1_NUMLINKS|FATTR4_WORD1_OWNER| > FATTR4_WORD1_OWNER_GROUP|FATTR4_WORD1_RAWDEV| Here as well, incuding in the existing code. Please add them and stick to the 80 character limit to make it somewhat readable (maybe even split to one flag per line?). Otherwise looks good: Reviewed-by: Christoph Hellwig