Re: [PATCH 0/6] nfs-utils: handle BAD_INTEGRITY ERROR

[Chuck Lever <chuck.lever@oracle.com>]

On Wed, Dec 06, 2023 at 04:33:26PM -0500, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> This patch series is re-work of the previous patch series that handles
> gss error for bad integrity. In this version, gssd is changed to use
> rpc_gss_seccreate() function in tirpc which exposes the gss errors to
> the caller. This functionality is further checked with configure for the
> presence of this function in the tirpc library.
> 
> Note that the current libtirpc (1.3.4 version) needs a fix to
> rpc_gss_seccreate() to work correctly for the gssd that passes in
> credentials to be used for the gss context establishement.
> 
> Olga Kornievskaia (6):
>   gssd: revert commit a5f3b7ccb01c
>   gssd: revert commit 513630d720bd
>   gssd: switch to using rpc_gss_seccreate()
>   gssd: handle KRB5_AP_ERR_BAD_INTEGRITY for machine credentials
>   gssd: handle KRB5_AP_ERR_BAD_INTEGRITY for user credentials
>   configure: check for rpc_gss_seccreate
> 
>  aclocal/libtirpc.m4    |  5 +++++
>  utils/gssd/gssd_proc.c | 26 +++++++++++++++++++++++---
>  2 files changed, 28 insertions(+), 3 deletions(-)

The added error reporting is very nice. I'm glad we could make it
work.

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

-- 
Chuck Lever