linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
	Chuck Lever <chuck.lever@oracle.com>,
	Trond Myklebust <trondmy@hammerspace.com>,
	snitzer@hammerspace.com
Subject: Re: [PATCH v5 00/19] nfs/nfsd: add support for localio
Date: Wed, 19 Jun 2024 13:57:00 -0400	[thread overview]
Message-ID: <ZnMb7NxuXnIikSQK@kernel.org> (raw)
In-Reply-To: <171878101003.14261.1089014272023335768@noble.neil.brown.name>

On Wed, Jun 19, 2024 at 05:10:10PM +1000, NeilBrown wrote:
> On Wed, 19 Jun 2024, Christoph Hellwig wrote:
> > What happened to the requirement that all protocol extensions added
> > to Linux need to be standardized in IETF RFCs?
> > 
> > 
> 
> Is that requirement documented somewhere?  Not that I doubt it, but it
> would be nice to know where it is explicit.  I couldn't quickly find
> anything in Documentation/
> 
> Can we get by without the LOCALIO protocol?
> 
> For NFSv4.1 we could use the server_owner4 returned by EXCHANGE_ID.  It
> is explicitly documented as being usable to determine if two servers are
> the same.

My first approach was to (ab)use EXCHANGE_ID. It worked, but it
required exporting a symbol to query the hash table local to
nfs4state, etc.  It wasn't very clean.. could it have been made
clean?: I guess... but in the end I elected to solve both v3 and v4.x in
the same way using LOCALIO protocol.

> For NFSv4.0 ... I don't think we should encourage that to be used.
> 
> For NFSv3 it is harder.  I'm not as ready to deprecate it as I am for
> 4.0.  There is nothing in NFSv3 or MOUNT or NLM that is comparable to
> server_owner4.  If krb5 was used there would probably be a server
> identity in there that could be used.
> I think the server could theoretically return an AUTH_SYS verifier in
> each RPC reply and that could be used to identify the server.  I'm not
> sure that is a good idea though.
> 
> Going through the IETF process for something that is entirely private to
> Linux seems a bit more than should be necessary..

I have to believe Christoph didn't appreciate this LOCALIO protocol is
an entirely private implementation detail to Linux (that allows client
and server handshake).  I've clarified that in Documentation (for v6).

Mike

  parent reply	other threads:[~2024-06-19 17:57 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 20:19 [PATCH v5 00/19] nfs/nfsd: add support for localio Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 01/19] nfs: pass nfs_client to nfs_initiate_pgio Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 02/19] nfs: pass descriptor thru nfs_initiate_pgio path Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 03/19] nfs: pass struct file to nfs_init_pgio and nfs_init_commit Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 04/19] sunrpc: add rpcauth_map_to_svc_cred_local Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 05/19] nfs_common: add NFS LOCALIO protocol extension enablement Mike Snitzer
2024-06-19  5:04   ` NeilBrown
2024-06-18 20:19 ` [PATCH v5 06/19] nfs/nfsd: add "localio" support Mike Snitzer
2024-06-18 21:28   ` Jeff Layton
2024-06-18 20:19 ` [PATCH v5 07/19] NFS: Enable localio for non-pNFS I/O Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 08/19] pnfs/flexfiles: Enable localio for flexfiles I/O Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 09/19] nfs: implement v3 and v4 client support for NFS_LOCALIO_PROGRAM Mike Snitzer
2024-06-19  5:30   ` NeilBrown
2024-06-19 13:18     ` Chuck Lever III
2024-06-18 20:19 ` [PATCH v5 10/19] nfsd: implement v3 and v4 server " Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 11/19] nfs/nfsd: consolidate {encode,decode}_opaque_fixed in nfs_xdr.h Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 12/19] nfs/localio: move managing nfsd_open_local_fh symbol to nfs_common Mike Snitzer
2024-06-18 21:32   ` Jeff Layton
2024-06-18 20:19 ` [PATCH v5 13/19] nfs/nfsd: ensure localio server always uses its network namespace Mike Snitzer
2024-06-18 21:36   ` Jeff Layton
2024-06-18 20:19 ` [PATCH v5 14/19] nfsd/localio: manage netns reference in nfsd_open_local_fh Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 15/19] nfsd: prepare to use SRCU to dereference nn->nfsd_serv Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 16/19] nfsd: " Mike Snitzer
2024-06-19 12:39   ` Jeff Layton
2024-06-19 17:26     ` Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 17/19] nfsd/localio: use SRCU to dereference nn->nfsd_serv in nfsd_open_local_fh Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 18/19] nfs/localio: use dedicated workqueues for filesystem read and write Mike Snitzer
2024-06-18 20:19 ` [PATCH v5 19/19] nfs: add Documentation/filesystems/nfs/localio.rst Mike Snitzer
2024-06-18 21:46   ` Chuck Lever
2024-06-19  5:47     ` NeilBrown
2024-06-19 18:27       ` Mike Snitzer
2024-06-19  5:49 ` [PATCH v5 00/19] nfs/nfsd: add support for localio Christoph Hellwig
2024-06-19  7:10   ` NeilBrown
2024-06-19  7:15     ` Christoph Hellwig
2024-06-19 10:09     ` Jeff Layton
2024-06-19 21:09       ` NeilBrown
2024-06-19 22:28         ` Jeff Layton
2024-06-19 22:46         ` Mike Snitzer
2024-06-20  5:16         ` Christoph Hellwig
2024-06-19 17:57     ` Mike Snitzer [this message]
2024-06-19 18:04       ` Chuck Lever III
2024-06-19 18:13         ` Mike Snitzer
2024-06-19 18:22           ` Chuck Lever III
2024-06-20  5:18       ` Christoph Hellwig
2024-06-19 14:02   ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnMb7NxuXnIikSQK@kernel.org \
    --to=snitzer@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=hch@infradead.org \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=snitzer@hammerspace.com \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).