From: Christoph Hellwig <hch@infradead.org>
To: cel@kernel.org
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Ben Coddington <bcodding@redhat.com>,
linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH] nfs/blocklayout: fput() needed for ENODEV error flow
Date: Wed, 19 Jun 2024 22:21:51 -0700 [thread overview]
Message-ID: <ZnO8byESzfdyftNm@infradead.org> (raw)
In-Reply-To: <20240619135255.176454-2-cel@kernel.org>
On Wed, Jun 19, 2024 at 09:52:56AM -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> A recently-added error flow needs to fput() the block device just
> like the other error flows in this area; otherwise the device is
> leaked.
>
> Fixes: d76c769c8db4 ("pnfs/blocklayout: Don't add zero-length pnfs_block_dev")
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-06-20 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 13:52 [PATCH] nfs/blocklayout: fput() needed for ENODEV error flow cel
2024-06-20 5:21 ` Christoph Hellwig [this message]
2024-06-20 9:34 ` Sagi Grimberg
2024-06-20 11:32 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnO8byESzfdyftNm@infradead.org \
--to=hch@infradead.org \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox