From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 3/3] nfsd: move error choice for incorrect object types to version-specific code.
Date: Mon, 29 Jul 2024 08:06:54 -0700 [thread overview]
Message-ID: <ZqewDtQbNwQlkfTp@infradead.org> (raw)
In-Reply-To: <20240729014940.23053-4-neilb@suse.de>
Beside the comment style nit noted in the last patch this looks good
and is a nice cleanup indeed:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-07-29 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 1:47 [PATCH 0/3] nfsd: move error code mapping to per-version code NeilBrown
2024-07-29 1:47 ` [PATCH 1/3] nfsd: Move error code mapping to per-version proc code NeilBrown
2024-07-29 15:04 ` Christoph Hellwig
2024-07-29 1:47 ` [PATCH 2/3] nfsd: be more systematic about selecting error codes for internal use NeilBrown
2024-07-29 15:05 ` Christoph Hellwig
2024-07-29 1:47 ` [PATCH 3/3] nfsd: move error choice for incorrect object types to version-specific code NeilBrown
2024-07-29 15:06 ` Christoph Hellwig [this message]
2024-08-08 10:37 ` Jeff Layton
2024-08-08 11:40 ` NeilBrown
2024-08-08 12:01 ` Jeff Layton
2024-08-08 22:00 ` NeilBrown
2024-08-09 12:34 ` Jeff Layton
2024-07-29 12:36 ` [PATCH 0/3] nfsd: move error code mapping to per-version code Jeff Layton
2024-07-29 15:16 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqewDtQbNwQlkfTp@infradead.org \
--to=hch@infradead.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox