Re: link error while compiling localio.c

[Mike Snitzer <snitzer@kernel.org>]

On Thu, Oct 10, 2024 at 07:35:10AM +0000, Janpieter Sollie via Bugspray Bot wrote:
> Janpieter Sollie added an attachment on Kernel.org Bugzilla:
> 
> Created attachment 306999
> kernel .config
> 
> tried both GCC and clang:
> Clang output:
> > ld.lld: error: undefined symbol: nfs_to
> > >>> referenced by localio.c:37 (fs/nfsd/localio.c:37)
> > >>>               vmlinux.o:(init_nfsd)
> > >>> referenced by localio.c:37 (/usr/src/linux/fs/nfsd/localio.c:37)
> > >>>               vmlinux.o:(nfsd_localio_ops_init)
> > 
> > ld.lld: error: undefined symbol: nfs_uuid_invalidate_clients
> > >>> referenced by nfsctl.c:2286 (/usr/src/linux/fs/nfsd/nfsctl.c:2286)
> > >>>               vmlinux.o:(nfsd_net_pre_exit)
> > 
> > ld.lld: error: undefined symbol: nfs_uuid_is_local
> > >>> referenced by localio.c:116 (/usr/src/linux/fs/nfsd/localio.c:116)
> > >>>               vmlinux.o:(localio_proc_uuid_is_local)
> GCC output:
> ld: fs/nfsd/nfsctl.o: in function `nfsd_net_pre_exit':
> nfsctl.c:(.text+0x122): undefined reference to `nfs_uuid_invalidate_clients'
> ld: fs/nfsd/localio.o: in function `localio_proc_uuid_is_local':
> /usr/src/linux/fs/nfsd/localio.c:116:(.text+0x56): undefined reference to `nfs_uuid_is_local'
> ld: fs/nfsd/localio.o: in function `nfsd_localio_ops_init':
> /usr/src/linux/fs/nfsd/localio.c:37:(.text+0x2c9): undefined reference to `nfs_to'
> 
> Command:
> make -j64 or make LLVM=1 -j64
> 
> the config file for GCC will be attached, let me know if the clang version is desired as well
> 
> As you might guess, not trimming the unused symbols fixes the issue ...
> 
> File: config.txt (text/plain)
> Size: 130.19 KiB
> Link: https://bugzilla.kernel.org/attachment.cgi?id=306999
> ---
> kernel .config
> 
> You can reply to this message to join the discussion.
> -- 
> Deet-doot-dot, I am a bot.
> Kernel.org Bugzilla (bugspray 0.1-dev)

I will report as much via bugzilla.kernel.org but for the benefit of those cc'd:

This was fixed via v6.12-rc3 commit 009b15b57485 ("nfs_common: fix
Kconfig for NFS_COMMON_LOCALIO_SUPPORT")

In the provided kernel config:

CONFIG_NFS_FS=m
CONFIG_NFSD_V4=y
CONFIG_NFS_COMMON=y
CONFIG_NFS_COMMON_LOCALIO_SUPPORT=m
CONFIG_NFS_LOCALIO=y

My Kconfig fix will result in CONFIG_NFS_LOCALIO=m so that the symbols
are available to the nfs.ko kernel module.

But if you have any further issues, certainly let me know.

Thanks,
Mike