From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0DC728FC for ; Fri, 1 Nov 2024 14:24:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730471046; cv=none; b=ois050+YDiJY6GO9pYlRReIJHiHcMeQowwy6tY4Qw85w8aN6Wkm2ftUUb1dEDJmn6z8hMOC1K8IZ39VODjsZXYRg7Ai77rYliQZlnzATnVJBQO0HNSAP6MpgUBEBDlzB7BJNHWimPGznDLCe9uEtpiymSXw0+v8Z+pFMnCIf8AU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730471046; c=relaxed/simple; bh=SRWHjcJRtTVMI/nwe3wzGfbOQG1E4/xkXgpjV6aMK94=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kq2OXaWmqABSia/WaZhNs4Vsptb1MJZFVTNrjo9mWoSbxVwdwvbzfPq+Pt/yhHonKdm3emHMkZqKmm8ydgZK72lXq0O+PUpjs4fWqcczjqSk/ubYl5eR1q74ugE73siDZLL4HAfbYl3JEV5yDsl20TMwINiPmbiv6FO+qX9ALcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aaNaLAVI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aaNaLAVI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730471043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vHXHxIcAV1ObOAeE5zmQlYU04+OBZrYT+UfX7EswcX4=; b=aaNaLAVIKY+77EM5JNCnn4dsJdSsD/KP26W0DdmUB2Nvt9Eg/Q4nr2qjYFPkwLHKiBOB1G H13y4y1CT9MRLl5kmcWKAA+IKSS5dv17rkcnP4TBie9qDXGUuzrhXBL+JAlE1jX5jwNgPE oJHQcScqV6iUsthQjvCSgfCz3ci6v+E= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-E-H98iAPOX2wE0OTcIO5wA-1; Fri, 01 Nov 2024 10:24:02 -0400 X-MC-Unique: E-H98iAPOX2wE0OTcIO5wA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D82F1955BC9; Fri, 1 Nov 2024 14:24:01 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.88.35]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E2E351956052; Fri, 1 Nov 2024 14:24:00 +0000 (UTC) Received: by aion.redhat.com (Postfix, from userid 1000) id CE48221D825; Fri, 1 Nov 2024 10:23:58 -0400 (EDT) Date: Fri, 1 Nov 2024 10:23:58 -0400 From: Scott Mayhew To: "Seiichi Ikarashi (Fujitsu)" Cc: "'steved@redhat.com'" , "'linux-nfs@vger.kernel.org'" , "'sorenson@redhat.com'" Subject: Re: [PATCH] Retry NFSv3 mount after NFSv4 failure in auto negotiation Message-ID: References: Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Fri, 18 Oct 2024, Seiichi Ikarashi (Fujitsu) wrote: > The problem happens when a v3 mount fails with ETIMEDOUT after > the v4 mount failed with EPROTONOSUPPORT, in mount auto negotiation. > It immediately breaks from the "for" loop in nfsmount_fg() > or nfsmount_child() due to EPROTONOSUPPORT, never doing the expected > retries until timeout. > > Let's retry in v3, too. > > Signed-off-by: Seiichi Ikarashi > --- > utils/mount/stropts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c > index a92c420..103c41f 100644 > --- a/utils/mount/stropts.c > +++ b/utils/mount/stropts.c > @@ -981,7 +981,7 @@ fall_back: > if ((result = nfs_try_mount_v3v2(mi, FALSE))) > return result; > > - if (errno != EBUSY && errno != EACCES) > + if (errno != EBUSY && errno != EACCES && errno != ETIMEDOUT) > errno = olderrno; > > return result; > This change looks good to me, but the patch itself doesn't apply (it has spaces instead of tabs). -Scott