Re: [PATCH v2 7/8] Set SB_POSIXACL if the server supports the extension

[Anna Schumaker <anna.schumaker@oracle.com>]

Hi Rick,

On 1/3/26 6:40 PM, rick.macklem@gmail.com wrote:
> From: Rick Macklem <rmacklem@uoguelph.ca>
> 
> Check to see if both the POSIX draft default ACL and
> POSIX draft access ACL are supported by the server.
> If so, set SB_POSIXACL.
> 
> Signed-off-by: Rick Macklem <rmacklem@uoguelph.ca>
> ---
>  fs/nfs/super.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index 57d372db03b9..aa0f53c3d01d 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -1352,6 +1352,11 @@ int nfs_get_tree_common(struct fs_context *fc)
>  		goto error_splat_super;
>  	}
>  
> +	/* Set SB_POSIXACL if the server supports the NFSv4.2 extension. */
> +	if ((server->attr_bitmask[2] & FATTR4_WORD2_POSIX_DEFAULT_ACL) &&
> +	    (server->attr_bitmask[2] & FATTR4_WORD2_POSIX_ACCESS_ACL))
> +		s->s_flags |= SB_POSIXACL;

Just a heads up that server->attr_bitmask only exists if the kernel is configured
with CONFIG_NFS_V4=y, so the compiler will complain about this:

fs/nfs/super.c:1348:15: error: no member named 'attr_bitmask' in 'struct nfs_server'
 1348 |         if ((server->attr_bitmask[2] & FATTR4_WORD2_POSIX_DEFAULT_ACL) &&
      |              ~~~~~~  ^
fs/nfs/super.c:1349:15: error: no member named 'attr_bitmask' in 'struct nfs_server'
 1349 |             (server->attr_bitmask[2] & FATTR4_WORD2_POSIX_ACCESS_ACL))
      |              ~~~~~~  ^
2 errors generated.

You'll probably need to either move it into NFS v4 specific code or hide it behind
and #ifdef.

Thanks,
Anna

> +
>  	s->s_flags |= SB_ACTIVE;
>  	error = 0;
>