From: Trond Myklebust <trondmy@hammerspace.com>
To: "jlayton@kernel.org" <jlayton@kernel.org>,
"bcodding@redhat.com" <bcodding@redhat.com>
Cc: "anna@kernel.org" <anna@kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
Date: Wed, 21 Aug 2024 16:18:17 +0000 [thread overview]
Message-ID: <a726dfdc9a57b4e04ef35f1ff52f56722df5b87b.camel@hammerspace.com> (raw)
In-Reply-To: <06fc6f0eab32ea183c5aace43ba08ea6ecfd9cf4.camel@kernel.org>
On Wed, 2024-08-21 at 12:06 -0400, Jeff Layton wrote:
> On Wed, 2024-08-21 at 12:04 -0400, Benjamin Coddington wrote:
> > On 15 Aug 2024, at 10:18, Jeff Layton wrote:
> >
> > > The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the
> > > initial
> > > SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the
> > > initial
> > > request.
> > >
> > > Fixes: 707f13b3d081 (NFSv4: Add support for the
> > > FATTR4_OPEN_ARGUMENTS attribute)
> > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> >
> > Clearly correct, save for slight style mismatch.
> >
> > Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
> >
> > Ben
> >
>
> Thanks. I noticed that after sending it. No objection if you want to
> fix that up before merging.
Ack to this too.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2024-08-21 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 14:18 [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS Jeff Layton
2024-08-21 12:20 ` Jeff Layton
2024-08-21 19:30 ` Anna Schumaker
2024-08-21 16:04 ` Benjamin Coddington
2024-08-21 16:06 ` Jeff Layton
2024-08-21 16:18 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a726dfdc9a57b4e04ef35f1ff52f56722df5b87b.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).