From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F295436D4E1 for ; Thu, 23 Apr 2026 17:57:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776967060; cv=none; b=iJJAC7GrXDnD6B9c2LM+sJi/Pm8JVAWiIMl5zyEUmWRmiOx5b9oSCrauhT1V3B3c9zhC9rkQPha3yrvnJ3kihJj6LxlkCZKs3PRSiulFLyTcUsWKeW9MP2vE2gWwWPbzY5xpym74hQrqxyX0Mu2288KeZoku4r2cbW1v6rQwXqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776967060; c=relaxed/simple; bh=k2/JeMnGIr+8Bq/rjASbVd0aErnX0ZsnqCRH1xGRGqQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iAVnBwdHISFp8Uek4Za2Q4I548MluO6VIXaVY4zitpKMAWQEX81UHczZdZjI2Cc6sbDbf7CP2op8qpzh20QRRN5zQr/DBBYCQEFSdOOuaaqV9g/fOmqAiUYH/MYwnidRYS8uVQtEzyQRk6ZOmud88CGYDBC86ESJEaGNtWckcJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e5t4zFjr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e5t4zFjr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC660C2BCAF; Thu, 23 Apr 2026 17:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776967059; bh=k2/JeMnGIr+8Bq/rjASbVd0aErnX0ZsnqCRH1xGRGqQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=e5t4zFjrfWa05ksGZZviYbIM+FfIuv0gEriLPfV7r0G2Aaw44UYrz1ckHzGNx3O/I iQQf3PqsPZg2c2+x8HqpTovR7CYeNIJKsAOn+lUCo0Tg+G5ldoAvlvzWrcF36I5tSX A6Rp+4oSRC7D9ImQCzF2anpn08bQKfikZuNQPRy0yFg0hLfByG5dE9Ri5LzXRgTefm MoVgseVY81gyBhDk+yIvL9r6QrVHovHy75eSO6P3iMexHyu/d/FIVgWLOIxKQNSQ/m cPOMtc7ZM5hlAvjpMeG7+330cZ8ZeukiT7UDiSsDOfJd8HiSlW77v7ys4B09RTVVOY xIfIwof7Pv70Q== Message-ID: Date: Thu, 23 Apr 2026 13:57:37 -0400 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] NFSD: Put cache get-reqs dump attrs under reply To: Jeff Layton , Thorsten Leemhuis , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-nfs@vger.kernel.org, Chuck Lever References: <20260423171732.322623-1-cel@kernel.org> <13219731-89be-4c49-8842-69935c21eb2f@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/23/26 10:50 AM, Jeff Layton wrote: > On Thu, 2026-04-23 at 13:26 -0400, Chuck Lever wrote: >> On 4/23/26 10:24 AM, Thorsten Leemhuis wrote: >>> On 4/23/26 19:17, Chuck Lever wrote: >>>> From: Chuck Lever >>>> >>>> The new get-reqs dump operations added to sunrpc_cache.yaml and >>>> nfsd.yaml place the "requests" nested attribute under dump.request. >>>> A netlink dump carries an empty request; its payload travels back >>>> in the reply. Because the spec names no reply attributes, the YNL >>>> C code generator synthesizes a forward reference to a >>>> _rsp struct that is never defined, breaking any consumer of >>>> these specs. >>>> >>>> This first surfaced when Thorsten Leemhuis built tools/net/ynl >>>> against -next: >>> >>> Thx for the quick fix, this makes things work. In case anybody cares: >>> >>> Tested-by: Thorsten Leemhuis >> >> Thanks! Applied to nfsd-next. >> >> > > Many thanks! I was just sitting down to look at Thorsten's mail. 'Twas my own damn fault: it was a merge-resolution-gone-wrong. -- Chuck Lever