From: Christoph Hellwig <hch@infradead.org>
To: Sergey Bashirov <sergeybashirov@gmail.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Konstantin Evtushenko <koevtushenko@yandex.com>
Subject: Re: [PATCH v2] nfsd: Use correct error code when decoding extents
Date: Thu, 12 Jun 2025 00:00:09 -0700 [thread overview]
Message-ID: <aEp6-T8Oqe2dI7of@infradead.org> (raw)
In-Reply-To: <20250611205504.19276-1-sergeybashirov@gmail.com>
On Wed, Jun 11, 2025 at 11:55:02PM +0300, Sergey Bashirov wrote:
> if (nr_iomaps < 0)
> - return nfserrno(nr_iomaps);
> + return cpu_to_be32(-nr_iomaps);
This still feels like an odd calling convention. Maybe we should just
change the calling convention to return the __be32 encoded nfs errno
and have a separate output argument for the number of iomaps?
Chuck, any preference?
next prev parent reply other threads:[~2025-06-12 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 20:55 [PATCH v2] nfsd: Use correct error code when decoding extents Sergey Bashirov
2025-06-12 7:00 ` Christoph Hellwig [this message]
2025-06-12 13:10 ` Chuck Lever
2025-06-12 15:57 ` Sergey Bashirov
2025-06-12 15:59 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEp6-T8Oqe2dI7of@infradead.org \
--to=hch@infradead.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=koevtushenko@yandex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=sergeybashirov@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox