From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <cel@kernel.org>
Cc: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC PATCH] NFSD: Use vfs_iocb_iter_read()
Date: Thu, 12 Jun 2025 22:35:23 -0700 [thread overview]
Message-ID: <aEu4m02hW6AZ8drd@infradead.org> (raw)
In-Reply-To: <20250613003653.532114-1-cel@kernel.org>
On Thu, Jun 12, 2025 at 08:36:53PM -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Refactor: Enable the use of RWF_ flags to control individual I/O
> operations.
The IOCB_ ones, really.
> + host_err = kiocb_set_rw_flags(&kiocb, 0, READ);
> + if (host_err) {
> + *count = 0;
> + goto out;
> + }
And if you don't want to explicitly convert from RWF_* flags, this
is pointless. Just drop it for now and explicitly set the IOCB_
flags we want once we add some.
prev parent reply other threads:[~2025-06-13 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 0:36 [RFC PATCH] NFSD: Use vfs_iocb_iter_read() Chuck Lever
2025-06-13 2:03 ` NeilBrown
2025-06-13 5:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEu4m02hW6AZ8drd@infradead.org \
--to=hch@infradead.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox