From: Mike Snitzer <snitzer@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
linux-nfs@vger.kernel.org, Mike Snitzer <snitzer@hammerspace.com>
Subject: Re: [RFC PATCH 5/6] nfs/localio: refactor iocb initialization
Date: Thu, 10 Jul 2025 03:32:54 -0400 [thread overview]
Message-ID: <aG9splp24KjMMZES@kernel.org> (raw)
In-Reply-To: <aG9qd8hwXpUlaqTS@infradead.org>
On Thu, Jul 10, 2025 at 12:23:35AM -0700, Christoph Hellwig wrote:
> > + // FIXME: would do well to allocate memory based on NUMA node.
> > + iocb->bvec = kmalloc_array(hdr->page_array.npages,
> > + sizeof(struct bio_vec), flags);
>
> I don't think that's a "FIXME". Either do it or leave it, but given
> that memory is allocated on the local node by default I can't see why
> that would be useful here for a short lived allocation.
Yeah, meant to remove that FIXME.. will do for v3.
next prev parent reply other threads:[~2025-07-10 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 16:20 [RFC PATCH 0/6] NFS: LOCALIO improvements and support for misaligned O_DIRECT READs Mike Snitzer
2025-07-08 16:20 ` [RFC PATCH 1/6] nfs/localio: avoid bouncing LOCALIO if nfs_client_is_local() Mike Snitzer
2025-07-08 16:20 ` [RFC PATCH 2/6] nfs/localio: add localio_async_probe modparm Mike Snitzer
2025-07-08 16:20 ` [RFC PATCH 3/6] nfs/localio: make trace_nfs_local_open_fh more useful Mike Snitzer
2025-07-08 16:20 ` [RFC PATCH 4/6] nfs/localio: add nfsd_file_dio_alignment Mike Snitzer
2025-07-08 16:20 ` [RFC PATCH 5/6] nfs/localio: refactor iocb initialization Mike Snitzer
2025-07-10 7:23 ` Christoph Hellwig
2025-07-10 7:32 ` Mike Snitzer [this message]
2025-07-08 16:20 ` [RFC PATCH 6/6] nfs/localio: fallback to NFSD for misaligned O_DIRECT READs Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG9splp24KjMMZES@kernel.org \
--to=snitzer@kernel.org \
--cc=anna@kernel.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=snitzer@hammerspace.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox