From: Mike Snitzer <snitzer@kernel.org>
To: Chuck Lever <cel@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Chuck Lever <chuck.lever@oracle.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna.schumaker@oracle.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/2 RFT] nfsd: fix another problem with recent localio changes
Date: Fri, 18 Jul 2025 10:36:13 -0400 [thread overview]
Message-ID: <aHpb3Yd5XuTl622Y@kernel.org> (raw)
In-Reply-To: <aHpZt4U38tcc5X89@kernel.org>
On Fri, Jul 18, 2025 at 10:27:03AM -0400, Mike Snitzer wrote:
> On Fri, Jul 18, 2025 at 10:25:26AM -0400, Chuck Lever wrote:
> > From: Chuck Lever <chuck.lever@oracle.com>
> >
> > On Fri, 18 Jul 2025 11:26:13 +1000, NeilBrown wrote:
> > > Mike reports ongoing problem with leakage of refcounts for the net in
> > > nfsd when localio is used. I believe the first patch fixes one possible
> > > cause. The second patch removes some related dead code.
> > >
> > > Mike: thanks for your testing so far. Hopefully you could find time to
> > > test this one too?
> > >
> > > [...]
> >
> > Applied to nfsd-testing, thanks!
> >
> > I assume 1/2 should be expedited? If so, I can add a Cc: stable and
> > get it into v6.17-rc.
>
> Yes, it should be expedited.
BTW, Neil's LOCALIO changes that were merged during 6.16 merge window
have dependencies on his generic wait_on_var advances. So all these
LOCALIO 6.16 changes won't have an easy time of getting back to 6.12
stable@ for example.
But given the Fixes: in the LOCALIO changes that were merged to 6.16
I'd imagine 6.14 stable@ _could_ pick them up... so explicitly tagging
this fix with "Cc: stable" likely makes sense. But had they picked up
the 6.16 patches for 6.14 stable@ then they should know to pick up
this fix anyway (as side-effect of Neil's Fixes: tag).
Chuck, pretty certain you know all this.. I'm just sharing what I know
for others' benefit.
prev parent reply other threads:[~2025-07-18 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 1:26 [PATCH 0/2 RFT] nfsd: fix another problem with recent localio changes NeilBrown
2025-07-18 1:26 ` [PATCH 1/2] nfsd: avoid ref leak in nfsd_open_local_fh() NeilBrown
2025-07-18 2:37 ` Mike Snitzer
2025-07-18 3:00 ` NeilBrown
2025-07-18 1:26 ` [PATCH 2/2] nfsd: discard nfsd_file_get_local() NeilBrown
2025-07-18 2:37 ` Mike Snitzer
2025-07-18 11:52 ` [PATCH 0/2 RFT] nfsd: fix another problem with recent localio changes Jeff Layton
2025-07-18 14:25 ` Chuck Lever
2025-07-18 14:27 ` Mike Snitzer
2025-07-18 14:36 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHpb3Yd5XuTl622Y@kernel.org \
--to=snitzer@kernel.org \
--cc=anna.schumaker@oracle.com \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox