From: Mike Snitzer <snitzer@kernel.org>
To: Scott Mayhew <smayhew@redhat.com>
Cc: trondmy@kernel.org, anna@kernel.org, zlang@redhat.com,
linux-nfs@vger.kernel.org
Subject: Re: nfs/localio: restore creds before releasing pageio data
Date: Thu, 7 Aug 2025 22:34:36 -0400 [thread overview]
Message-ID: <aJViPHUfZDQmpMpj@kernel.org> (raw)
In-Reply-To: <20250807164938.2395136-1-smayhew@redhat.com>
On Thu, Aug 07, 2025 at 12:49:38PM -0400, Scott Mayhew wrote:
> Otherwise if the nfsd filecache code releases the nfsd_file
> immediately, it can trigger the BUG_ON(cred == current->cred) in
> __put_cred() when it puts the nfsd_file->nf_file->f-cred.
>
> Fixes: b9f5dd57f4a5 ("nfs/localio: use dedicated workqueues for filesystem read and write")
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
> Mike - I applied the four patches you mentioned and I still see the oops
> quite frequently. This patch fixes it for me.
Looks good. Interesting that I've never experienced this BUG_ON.
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
Thanks!
prev parent reply other threads:[~2025-08-08 2:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 5:18 [Bug report] xfstests cause nfs crash, kernel BUG at kernel/cred.c:104! Zorro Lang
2025-06-04 17:18 ` Mike Snitzer
2025-06-06 2:38 ` Zorro Lang
2025-08-05 22:34 ` Scott Mayhew
2025-08-05 23:30 ` Mike Snitzer
2025-08-07 16:49 ` [PATCH] nfs/localio: restore creds before releasing pageio data Scott Mayhew
2025-08-08 2:34 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJViPHUfZDQmpMpj@kernel.org \
--to=snitzer@kernel.org \
--cc=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
--cc=trondmy@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).