From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 151CC306B38 for ; Wed, 15 Oct 2025 13:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760533781; cv=none; b=Ue2u0bPWMPhsK40xHuH2gB58bG2NKR580cscfUdRZAxS+4A75S1CRRlpSz6XmBy0pDgON5c6FfkNKIJby1VMXsUaO8ohXifV1B27WIi/onE9eLWTLDbhgnOogaw8PLBMd27RHD8RUU4zng5krB1JC2UrTLbxicm7JJRKbH3eQTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760533781; c=relaxed/simple; bh=YK9aOZeHNkY1kiFuWwLpkT3drPBlu2gU3r4Z4OMzKCg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MFeoL8h+PKc0HEeOnXN5K8gsVnSCL4FU2NMsojNkU1QDzk2CLWQ9OnGEEvz9DGjHiKmtw41T24cgQcSHoXYyYxRJlpEch5hCrZ3DHiuB79l/5egPsRAW2NZDNPKRrifGfOSM3hXclLPJ5M7YUksbcb/BU4bh0tgVjN0iFIpU9FE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZkszoTHi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZkszoTHi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 736B9C116C6; Wed, 15 Oct 2025 13:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760533780; bh=YK9aOZeHNkY1kiFuWwLpkT3drPBlu2gU3r4Z4OMzKCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZkszoTHizQFJbaMnnM79C2Ugg1qbahbd5KsTHlRjTbiL5VLlxcDMt1hs08ZZKbmJN 3Bwcnq9ZW8QNlTyuiA6ahF7RX/ZTdYCD9/aLreu93F7lqois7GGTyZ9d1TKarnU2C6 2vL4PEh2mY4Syp+LfUWuOKJR38yY389qW/cmPCwx526ntLV6en2bUnHhhHbfwZ8MEV dpXAmXcSQ2nP06jz0wbLjpqBEV0eAUdEaUP3So7Foa7YqFYuYevxSq5HsC7Or2HkeY z9UTDGSDnnH15FdN+fJhCVDbK/nuEm9Foyac++QkQZ09lkyJT+YXzkG54MqDod5DSu EgKnzUdLLQhOg== Date: Wed, 15 Oct 2025 09:09:39 -0400 From: Mike Snitzer To: Jonathan Curley Cc: Trond Myklebust , Anna Schumaker , Luis Chamberlain , linux-nfs@vger.kernel.org Subject: Re: [RFC PATCH v4 0/9] NFSv4/flexfiles: Add support for striped layouts Message-ID: References: <20250924162050.634451-1-jcurley@purestorage.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250924162050.634451-1-jcurley@purestorage.com> Hi Jon, I got a report that TLS no longer works with flexfiles. For context, I made TLS possible with flexfiles with commit 04a15263662a ("pnfs/flexfiles: connect to NFSv3 DS using TLS if MDS connection uses TLS"). If I revert your flexfiles striped patchset then TLS works with flexfiles again. I haven't looked closely to try to find the issue yet, but I wanted to let you (and others) know about this regression. Mike On Wed, Sep 24, 2025 at 04:20:41PM +0000, Jonathan Curley wrote: > This patch series introduces support for striped layouts: > > The first 2 patches are simple preparation changes. There should be > no logical impact to the code. > > The 3rd patch refactors the nfs4_ff_layout_mirror struct to have an > array of a new nfs4_ff_layout_ds_stripe type. The > nfs4_ff_layout_ds_stripe has all the contents of ff_data_server4 per > the flexfile rfc. I called it ds_stripe because ds was already taken > by the deviceid side of the code. > > The patches 4-8 update various paths to be dss_id aware. Most of this > consists of either adding a new parameter to the function or adding a > loop. Depending on which is appropriate. > > The final patch 9 updates the layout creation path to populate the > array and turns the feature on. > > v1: > - Fixes function parameter 'dss_id' not described in > 'nfs4_ff_layout_prepare_ds' > > v2: > - Fixes layout stat error reporting path for commit to properly > calculate dss_id. > > v3: > - Fixes do_div dividend to be u64. > > v4: > - Use regular division operators for u32 commit path math. > - Fix mirror null check in ff_rw_layout_has_available_ds. > > Jonathan Curley (9): > NFSv4/flexfiles: Remove cred local variable dependency > NFSv4/flexfiles: Use ds_commit_idx when marking a write commit > NFSv4/flexfiles: Add data structure support for striped layouts > NFSv4/flexfiles: Update low level helper functions to be DS stripe > aware. > NFSv4/flexfiles: Read path updates for striped layouts > NFSv4/flexfiles: Commit path updates for striped layouts > NFSv4/flexfiles: Write path updates for striped layouts > NFSv4/flexfiles: Update layout stats & error paths for striped layouts > NFSv4/flexfiles: Add support for striped layouts > > fs/nfs/flexfilelayout/flexfilelayout.c | 778 +++++++++++++++------- > fs/nfs/flexfilelayout/flexfilelayout.h | 64 +- > fs/nfs/flexfilelayout/flexfilelayoutdev.c | 105 +-- > fs/nfs/write.c | 2 +- > 4 files changed, 635 insertions(+), 314 deletions(-) > > -- > 2.34.1 > >