Re: [RFC PATCH 05/10] Add make_test_acl() helper to nfs4acl modules

[Chuck Lever <cel@kernel.org>]

On Sun, Nov 23, 2025 at 10:56:13AM -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>

Yes, clearly these need a little more clean-up: This patch
and a few following ones need real commit messages.


> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  nfs4.0/nfs4acl.py | 22 ++++++++++++++++++++++
>  nfs4.1/nfs4acl.py | 23 +++++++++++++++++++++++
>  2 files changed, 45 insertions(+)
> 
> diff --git a/nfs4.0/nfs4acl.py b/nfs4.0/nfs4acl.py
> index ceb9ea6a198e..329be01f9fd6 100644
> --- a/nfs4.0/nfs4acl.py
> +++ b/nfs4.0/nfs4acl.py
> @@ -78,6 +78,28 @@ def mode2acl(mode, dir=False):
>               nfsace4(DENIED, 0, negate(other), "EVERYONE@")
>               ]
>  
> +def make_test_acl():
> +    """Create a test ACL that maps cleanly to POSIX ACLs
> +
> +    Uses OWNER@, GROUP@, and EVERYONE@ to match POSIX user/group/other
> +    structure, which helps servers that map NFSv4 ACLs to POSIX ACLs.
> +
> +    Includes both WRITE_DATA and APPEND_DATA for write permission, since
> +    Linux NFS server's conservative NFSv4-to-POSIX mapping requires both
> +    to grant POSIX write permission.
> +    """
> +    return [
> +        nfsace4(ACE4_ACCESS_ALLOWED_ACE_TYPE, 0,
> +                ACE4_READ_DATA | ACE4_WRITE_DATA | ACE4_APPEND_DATA | ACE4_READ_ACL,
> +                b"OWNER@"),
> +        nfsace4(ACE4_ACCESS_ALLOWED_ACE_TYPE, 0,
> +                ACE4_READ_DATA,
> +                b"GROUP@"),
> +        nfsace4(ACE4_ACCESS_ALLOWED_ACE_TYPE, 0,
> +                ACE4_READ_DATA,
> +                b"EVERYONE@")
> +    ]
> +
>  def acl2mode(acl):
>      """Translate an acl into a 3-digit octal mode"""
>      names = ["OWNER@", "GROUP@", "EVERYONE@"]
> diff --git a/nfs4.1/nfs4acl.py b/nfs4.1/nfs4acl.py
> index 44f01de0d513..f4d4993b143b 100644
> --- a/nfs4.1/nfs4acl.py
> +++ b/nfs4.1/nfs4acl.py
> @@ -3,6 +3,29 @@
>  #
>  
>  from xdrdef.nfs4_const import *
> +from xdrdef.nfs4_type import nfsace4
> +
> +def make_test_acl():
> +    """Create a test ACL that maps cleanly to POSIX ACLs
> +
> +    Uses OWNER@, GROUP@, and EVERYONE@ to match POSIX user/group/other
> +    structure, which helps servers that map NFSv4 ACLs to POSIX ACLs.
> +
> +    Includes both WRITE_DATA and APPEND_DATA for write permission, since
> +    Linux NFS server's conservative NFSv4-to-POSIX mapping requires both
> +    to grant POSIX write permission.
> +    """
> +    return [
> +        nfsace4(ACE4_ACCESS_ALLOWED_ACE_TYPE, 0,
> +                ACE4_READ_DATA | ACE4_WRITE_DATA | ACE4_APPEND_DATA | ACE4_READ_ACL,
> +                b"OWNER@"),
> +        nfsace4(ACE4_ACCESS_ALLOWED_ACE_TYPE, 0,
> +                ACE4_READ_DATA,
> +                b"GROUP@"),
> +        nfsace4(ACE4_ACCESS_ALLOWED_ACE_TYPE, 0,
> +                ACE4_READ_DATA,
> +                b"EVERYONE@")
> +    ]
>  
>  def acl2mode_rfc8881(acl):
>      """
> -- 
> 2.51.1
> 
> 

-- 
Chuck Lever