From: Christoph Hellwig <hch@infradead.org>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: trondmy@kernel.org, anna@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 1/1] pNFS: Serialize SCSI PR registration to avoid reservation conflicts
Date: Thu, 5 Mar 2026 06:18:15 -0800 [thread overview]
Message-ID: <aamQp47da-soFtuB@infradead.org> (raw)
In-Reply-To: <20260304194931.2592156-1-dai.ngo@oracle.com>
> - if (test_and_set_bit(PNFS_BDEV_REGISTERED, &dev->flags))
> + mutex_lock(&dev->pbd_registration_mutex);
> + if (dev->flags & BIT(PNFS_BDEV_REGISTERED)) {
dev->flags can now become a simple unsigned int, and you can
define PNFS_BDEV_REGISTERED as an actual value instead of using
BIT everywhere.
Otherwise this looks good.
prev parent reply other threads:[~2026-03-05 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 19:49 [PATCH v2 1/1] pNFS: Serialize SCSI PR registration to avoid reservation conflicts Dai Ngo
2026-03-05 14:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aamQp47da-soFtuB@infradead.org \
--to=hch@infradead.org \
--cc=anna@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox