Linux NFS development
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Chuck Lever <chuck.lever@oracle.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Jeff Layton <jlayton@kernel.org>,
	Neil Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>,
	Tom Talpey <tom@talpey.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] nfsd: Use seq_putc() in seq_quote_mem()
Date: Sat, 13 Jul 2024 21:16:14 +0200	[thread overview]
Message-ID: <ab25204c-5a53-42e1-ab3a-c4f704ebc929@web.de> (raw)

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 13 Jul 2024 21:07:09 +0200

Double quotation characters should be put into a sequence
around other data.
Thus use the function “seq_putc” accordingly.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 fs/nfsd/nfs4state.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index a20c2c9d7d45..1d15165a15cf 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2636,9 +2636,9 @@ static struct nfs4_client *get_nfsdfs_clp(struct inode *inode)

 static void seq_quote_mem(struct seq_file *m, char *data, int len)
 {
-	seq_puts(m, "\"");
+	seq_putc(m, '"');
 	seq_escape_mem(m, data, len, ESCAPE_HEX | ESCAPE_NAP | ESCAPE_APPEND, "\"\\");
-	seq_puts(m, "\"");
+	seq_putc(m, '"');
 }

 static const char *cb_state2str(int state)
--
2.45.2


                 reply	other threads:[~2024-07-13 19:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab25204c-5a53-42e1-ab3a-c4f704ebc929@web.de \
    --to=markus.elfring@web.de \
    --cc=Dai.Ngo@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kolga@netapp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox